e2e: Fix Debug logging should be visible in multus pod flake
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 7753914139
💛 - Coveralls |
adrianchiris
reviewed
Feb 1, 2024
| Eventually(func() error { | ||
| netAttDef := &netattdefv1.NetworkAttachmentDefinition{} | ||
| return clients.Get(context.Background(), runtimeclient.ObjectKey{Name: sriovNetworkName, Namespace: ns1}, netAttDef) | ||
| }, (30+snoTimeoutMultiplier*90)*time.Second, 1*time.Second).ShouldNot(HaveOccurred()) |
There was a problem hiding this comment.
two comments:
- can we call waitForNetAttachDef(...) in L841 as well ?
- we now wait 10 seconds and not 30 when muliplier is 0 , if it doesnt fail i guess that is ok.
There was a problem hiding this comment.
two comments:
- can we call waitForNetAttachDef(...) in L841 as well ?
sure! didn't see it
- we now wait 10 seconds and not 30 when muliplier is 0 , if it doesnt fail i guess that is ok.
I found no reason for having 30s instead of 10s:
- bed21a0#diff-8841b252b9d2e29927af1036582b38ac8466067019d67dd5a59f22285674310dR507
- 0cfd998#diff-8841b252b9d2e29927af1036582b38ac8466067019d67dd5a59f22285674310dR642
I'd go with this and see if it flakes.
Once the SriovNetwork has been created, test routine must wait for NetAttachDefinition
to be created by the operator before spawing pods. Create a function `waitForNetAttachDef(...)`
and use it in similar situations.
The flake error this commit is supposed to fix is:
```
• [FAILED] [2.695 seconds]
[sriov] operator Generic SriovNetworkNodePolicy CNI Logging level [It] Debug logging should be visible in multus pod
/root/opr-k8s-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:1077
[FAILED] Unexpected error:
<*errors.StatusError | 0xc000fd8640>:
admission webhook "network-resources-injector-config.k8s.io" denied the request: could not find network attachment definition 'sriov-conformance-testing/test-log-level-debug-no-file': could not get Network Attachment Definition sriov-conformance-testing/test-log-level-debug-no-file: the server could not find the requested resource
{
ErrStatus: {
TypeMeta: {Kind: "", APIVersion: ""},
ListMeta: {
SelfLink: "",
ResourceVersion: "",
Continue: "",
RemainingItemCount: nil,
},
Status: "Failure",
Message: "admission webhook \"network-resources-injector-config.k8s.io\" denied the request: could not find network attachment definition 'sriov-conformance-testing/test-log-level-debug-no-file': could not get Network Attachment Definition sriov-conformance-testing/test-log-level-debug-no-file: the server could not find the requested resource",
Reason: "",
Details: nil,
Code: 400,
},
}
occurred
In [It] at: /root/opr-k8s-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_sriov_operator.go:2505 @ 02/01/24 12:44:25.702
```
Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
e2e-debug-loggin-flake
branch
from
a93061e to
20c08f5
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the SriovNetwork has been created, the test routine must wait for NetAttachDefinition to be created by the operator before spawning pods. Create a function
waitForNetAttachDef(...)and use it in similar situations.The flake error this commit is supposed to fix is: