Refactor controller tests #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adrianchiris
commented
Feb 1, 2024
adrianchiris
commented
- Move Manager creation and initialization to each controller test
- Move creation of k8s objs that are not common for all controllers to each controller test
- Use ordered containers to only setup manager once per controller test
- remove the usage of context.TODO() from tests
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Hopefully this will conclude the refactoring/fixes for controller tests for the near future .... :) |
Pull Request Test Coverage Report for Build 7774621818
💛 - Coveralls |
- Move Manager creation and initialization to each controller test - Move creation of k8s objs that are not common for all controllers to each controller test - Use ordered containers to only setup manager once per controller test - remove the usage of context.TODO() from tests Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
init-manager-in-each-test
branch
from
14a2c1b to
01e5922
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
PR rebased. @zeeke could you re-approve so we can merge this one once CI passes ? |
|
multus flake in ocp test. not related to this PR. IMO we can proceed with merging this one. |
zeeke
approved these changes
Feb 5, 2024
adrianchiris
merged commit d131e98
into
k8snetworkplumbingwg:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.