Move default policy creation in controller tests to BeforeSuite. #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to fix the following problem: SriovOperatorConfigReconciler starts in the BeforeSuite handler, the default OperatorConfig is also created in BeforeSuite. That means the SriovOperatorConfigReconciler will be triggered with the first test in the controller suite. SriovOperatorConfigReconciler will fail (return an error) until DefaultPolicy is created by the BeforeEach function in sriovoperatorconfig_controller_test.go. The problem is that tests in sriovoperatorconfig_controller_test.go starts after the test in some other *_test.go files in the controller package. At the time when tests from sriovoperatorconfig_controller_test.go are eventually executed, SriovOperatorConfigReconciler controller is already failed multiple times in a row (because there was no default policy) and is waiting with a backoff delay (already quite large) before reconcilation retry. Signed-off-by: Yury Kulazhenkov <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
approved these changes
Jan 31, 2024
e0ne
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to fix the following problem:
SriovOperatorConfigReconciler starts in the BeforeSuite handler, the default OperatorConfig is also created in BeforeSuite. That means the SriovOperatorConfigReconciler will be triggered with the first test in the controller suite.
SriovOperatorConfigReconciler will fail (return an error) until DefaultPolicy is created by the BeforeEach function in sriovoperatorconfig_controller_test.go.
The problem is that tests in sriovoperatorconfig_controller_test.go starts after the test in some other *_test.go files in the controller package. At the time when tests from sriovoperatorconfig_controller_test.go are eventually executed, SriovOperatorConfigReconciler controller is already failed multiple times in a row (because there was no default policy) and is waiting with a backoff delay (already quite large) before reconcilation retry.