Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move namespace to vars pkg #601

Merged

Conversation

adrianchiris
Copy link
Collaborator

Namespace variable is used in both controllers and daemon. Move it to vars pkg and use in both.

Namespace variable is used in both controllers and daemon.
Move it to vars pkg and use in both.

Signed-off-by: adrianc <[email protected]>
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris requested a review from zeeke January 30, 2024 13:44
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7712091360

  • -13 of 32 (59.38%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 25.104%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 8 9 88.89%
pkg/daemon/event_recorder.go 0 1 0.0%
controllers/sriovoperatorconfig_controller.go 5 7 71.43%
pkg/daemon/writer.go 0 2 0.0%
controllers/sriovnetworknodepolicy_controller.go 1 8 12.5%
Totals Coverage Status
Change from base Build 7709129442: 0.05%
Covered Lines: 2776
Relevant Lines: 11058

💛 - Coveralls

@adrianchiris
Copy link
Collaborator Author

failure does not seem to be reelated. merging this one.

@adrianchiris adrianchiris merged commit ea0e327 into k8snetworkplumbingwg:master Jan 31, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants