Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use APITimeout and RetryInterval constant in tests #600

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Use APITimeout and RetryInterval constant in tests #600

merged 1 commit into from
Jan 31, 2024

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jan 30, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7711744357

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 25.124%
Totals Coverage Status
Change from base Build 7709129442: 0.07%
Covered Lines: 2778
Relevant Lines: 11057
💛 - Coveralls

@e0ne e0ne changed the title Use APITimeout contant in tests Use APITimeout and RetryInterval constant in tests Jan 30, 2024
@mlguerrero12
Copy link
Contributor

LGTM

@mlguerrero12 mlguerrero12 mentioned this pull request Jan 30, 2024
Merged
adrianchiris
adrianchiris reviewed Jan 31, 2024
View reviewed changes
controllers/sriovnetworkpoolconfig_controller_test.go
@@ -65,7 +66,7 @@ var _ = Describe("Operator", func() {
return err
}
return nil
}, timeout*3, interval).Should(Succeed())
}, util.APITimeout*3, util.RetryInterval).Should(Succeed())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd that we need it. probably related to where this test is executed.

i mean we just spin up apiserver +etcd with envtest then a simple reconcile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, that's something we have to fix in the future in a sepatare PR

@e0ne e0ne requested a review from zeeke January 31, 2024 08:49
zeeke
zeeke approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the error this PR is fixing on my local environment, but looking at the CI, it fixes the job.

LGTM

@zeeke zeeke merged commit 8b36f09 into k8snetworkplumbingwg:master Jan 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e0ne @coveralls @mlguerrero12 @zeeke @adrianchiris