Test fixes and enhancements #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove redundant "vet" target as lint tests already cover its functionality - remove commented out code - add option to provide specific pkgs to test in make test target via TESTPKGS env var, preserving current behaviour if not provided Signed-off-by: adrianc <[email protected]>
Add step to run controller tests with k8s cluster type as well. Signed-off-by: adrianc <[email protected]>
its not needed to start envtest. moreover without this change, envtest environment would have remained running in the system as it was not stopped when test finished. Signed-off-by: adrianc <[email protected]>
- skip sriovnetworkpoolconfig only test-case in kubernetes cluster as it only valid for openshift. - general: only stop envtest if it was successfully started to avoid nil pointer dereference in case system was missconfigured since AfterSuite Ginkgo node would run even if BeforeSuite node failed Signed-off-by: adrianc <[email protected]>
- remove deprecated use of async node - fail if creating client returned nil - use ptr pkg instead of pointer package as its deprecated Signed-off-by: adrianc <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@andreaskaris PTAL |
Pull Request Test Coverage Report for Build 7696741691
💛 - Coveralls |
|
thx @zeeke, merging this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes/enhancements to tests and their execution. refer to individual commits for more info