Add more checks on generic plugin to discover discrepancies from the desired state #587

vasrem · 2024-01-17T11:30:33Z

Summary

This PR does the following things:

Adds additional test coverage for OnNodeStateChange() function to indicate when we are draining the node
Adjusts NeedToUpdateSriov() helper function to ensure that:
- VF MAC Address is set when we are in Ethernet mode
- VF GUID is set when we are in Ethernet mode and RDMA is enabled
- VF GUID is set when we are in Infiniband mode
- PF Link is up
(API Change) Adds necessary fields in the SriovNetworkNodeState struct to facilitate the above

Partial Reconciliation

Today we reconcile on .spec change since we skip reconciliation if the generation of the object is the same as the object that was last reconciled successfully. Therefore, changes in .status, like what we try to detect with that PR, are not reconciled unless the .spec changes when the config daemon runs continuously (i.e. no restart). On daemon restart, the .status field will be reconciled the first time until the last successfully reconciled generation is saved in memory.

Decisions

Decided to add tests on the OnNodeStateChange() instead of NeedToUpdateSriov() because that one looks to be the most impactful for the whole system (i.e. decides whether to drain). I can add on both Apply() and OnNodeStateChange() if we choose to split the NeedToUpdateSriov() (see open questions below).
Decided to just look for Node GUID and not the Port GUID since we expect both of them to be populated together on bind/unbind. This is the case because we parse the GUID from the RDMA link, and the node GUID is populated there on bind/unbind.

Open questions

Is it enough to partially reconcile or do we need to change the logic to take into account changes on .status (i.e. full reconciliation of changes that the controller does to the system)? (relatively big change in the operator behaviour I suppose)
Do we need to drain on any of the discrepancies we find? (e.g. link is not up). If not, we will need to adjust the function that is used in Apply() and OnNodeStateChange() to be something different than NeedToUpdateSriov().
Are there additional end to end tests to be added? I would appreciate if you can point out the place I should be putting those (if we want to test end to end).

Do we prefer getting info by reading directly /sys/class/net/* or use netlink? I see both approaches:

sriov-network-operator/pkg/host/network.go

Lines 195 to 205 in 09c987a

    
           func (n *network) GetNetDevMac(ifaceName string) string { 
        
           	log.Log.V(2).Info("GetNetDevMac(): get Mac", "device", ifaceName) 
        
           	macFilePath := filepath.Join(vars.FilesystemRoot, consts.SysClassNet, ifaceName, "address") 
        
           	data, err := os.ReadFile(macFilePath) 
        
           	if err != nil { 
        
           		log.Log.Error(err, "GetNetDevMac(): fail to read Mac file", "path", macFilePath) 
        
           		return "" 
        
           	} 
        
           	return strings.TrimSpace(string(data)) 
        
           }

sriov-network-operator/pkg/host/sriov.go

Lines 618 to 635 in 09c987a

    
           func (s *sriov) GetLinkType(ifaceStatus sriovnetworkv1.InterfaceExt) string { 
        
           	log.Log.V(2).Info("GetLinkType()", "device", ifaceStatus.PciAddress) 
        
           	if ifaceStatus.Name != "" { 
        
           		link, err := netlink.LinkByName(ifaceStatus.Name) 
        
           		if err != nil { 
        
           			log.Log.Error(err, "GetLinkType(): failed to get link", "device", ifaceStatus.Name) 
        
           			return "" 
        
           		} 
        
           		linkType := link.Attrs().EncapType 
        
           		if linkType == "ether" { 
        
           			return consts.LinkTypeETH 
        
           		} else if linkType == "infiniband" { 
        
           			return consts.LinkTypeIB 
        
           		} 
        
           	} 
        
           	return "" 
        
           }

Based on the answer I will use or discard d18aae1

github-actions · 2024-01-17T11:30:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T11:33:09Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T11:37:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T11:53:59Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-01-17T11:59:15Z

Pull Request Test Coverage Report for Build 9206688050

Details

54 of 127 (42.52%) changed or added relevant lines in 7 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.06%) to 39.655%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/lib/netlink/netlink.go	0	6	0.0%
pkg/host/internal/sriov/sriov.go	1	12	8.33%
pkg/host/internal/network/network.go	19	35	54.29%
pkg/helper/mock/mock_helper.go	0	20	0.0%
pkg/host/mock/mock_host.go	0	20	0.0%

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller.go	1	68.06%
controllers/generic_network_controller.go	5	74.53%

Totals
Change from base Build 9203023396:	0.06%
Covered Lines:	5175
Relevant Lines:	13050

💛 - Coveralls

github-actions · 2024-01-17T12:46:10Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T13:13:45Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T14:11:37Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T14:13:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-17T14:15:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-18T14:31:55Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-18T14:33:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

vasrem · 2024-01-19T06:39:28Z

/test-e2e-all

github-actions · 2024-01-19T06:58:21Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-01-29T07:54:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

vasrem · 2024-01-29T08:02:58Z

@adrianchiris PTAL

api/v1/helper.go

api/v1/sriovnetworknodestate_types.go

github-actions · 2024-05-08T10:36:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris · 2024-05-08T14:08:00Z

api/v1/helper.go

@@ -300,6 +306,28 @@ func NeedToUpdateSriov(ifaceSpec *Interface, ifaceStatus *InterfaceExt) bool {
 							return true
 						}

+						if strings.EqualFold(ifaceStatus.LinkType, consts.LinkTypeETH) {


nit: any chance to have one check to avoid duplication ?

e.g if (ETH && RDMA) || IB { ....}

Yeap, makes sense. Addressing.

adrianchiris

overall LGTM, one minor nit, sorry for not raising it in the previous round.

github-actions · 2024-05-08T16:08:59Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke · 2024-05-09T07:55:57Z

pkg/host/internal/network/network.go

@@ -187,6 +190,36 @@ func (n *network) GetNetDevMac(ifaceName string) string {
 	return link.Attrs().HardwareAddr.String()
 }

+// GetNetDevNodeGUID returns the network interface node GUID if device is RDMA capable otherwise returns empty string
+func (n *network) GetNetDevNodeGUID(pciAddr string) string {
+	log.Log.V(2).Info("GetNetDevNodeGUID(): get node GUID", "pciAddr", pciAddr)


This function gets called during the polling of NIC status, for each configured VF.
I would avoid this logging statement, as it increases config-daemon logs without adding specific value.

You can have a look at the end2end job artifact
https://github.com/k8snetworkplumbingwg/sriov-network-operator/actions/runs/9005014290/artifacts/1484967983

Agreed, removed.

github-actions · 2024-05-10T08:26:59Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris · 2024-05-13T07:25:10Z

@zeeke @SchSeba can we get that merged ?

vasrem · 2024-05-21T10:56:40Z

@zeeke and @SchSeba bump on that one if you could take a look.

SchSeba

sorry it took soo much time to merge this one.

It's almost remove just small comments and we can merge this PR

SchSeba · 2024-05-22T09:24:42Z

pkg/host/internal/network/network.go

+	}
+
+	if link.Attrs().Flags&net.FlagUp == 0 {
+		return "down"


please put this one as a const and use it also in https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/587/files#diff-371d95e79c61d8cc1e6791d27e009289552efcaada38f9b2fc75ebb487c90ea7R275

SchSeba · 2024-05-22T09:24:49Z

pkg/host/internal/network/network.go

+		return "down"
+	}
+
+	return "up"


please put this one as a const

SchSeba · 2024-05-22T09:26:20Z

pkg/host/internal/sriov/sriov.go

@@ -571,7 +574,7 @@ func (s *sriov) configSriovDevice(iface *sriovnetworkv1.Interface, skipVFConfigu
 	if err != nil {
 		return err
 	}
-	if pfLink.Attrs().OperState != netlink.OperUp {
+	if pfLink.Attrs().Flags&net.FlagUp == 0 {


please put this one as part of the netlinkLib lets use it here and on the other place in the code

Today, we are missing 2 checks on settings that sriov netop is configuring: * PF is up * GUID is set Without checking for these 2, we risk that changes made by the user directly to the system are not reconciled by the netop leaving the system in a bad state. This commit is adding those checks. Signed-off-by: Vasilis Remmas <[email protected]>

github-actions · 2024-05-23T10:30:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

vasrem · 2024-05-23T10:31:07Z

@SchSeba please have a look, I addressed your comments.

Signed-off-by: Vasilis Remmas <[email protected]>

github-actions · 2024-05-23T10:50:43Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba

nice work!

sorry about the amount of time the review took

Merge issue coming from - k8snetworkplumbingwg#690 - k8snetworkplumbingwg#587 Signed-off-by: Andrea Panattoni <[email protected]>

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 7d4380a to 2e88940 Compare January 17, 2024 11:33

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 2e88940 to f942ac6 Compare January 17, 2024 11:36

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from f942ac6 to 54a1148 Compare January 17, 2024 11:53

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 54a1148 to efe6e46 Compare January 17, 2024 12:45

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 3826a39 to c07958d Compare January 17, 2024 14:11

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from c07958d to 69c9dd5 Compare January 17, 2024 14:13

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 69c9dd5 to d18aae1 Compare January 17, 2024 14:15

vasrem marked this pull request as ready for review January 18, 2024 09:05

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from d18aae1 to 7fe0497 Compare January 18, 2024 14:31

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 7fe0497 to 4d50701 Compare January 18, 2024 14:32

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 4d50701 to f9e4337 Compare January 19, 2024 06:58

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from f9e4337 to 1ffcbc3 Compare January 29, 2024 07:53

adrianchiris reviewed Jan 29, 2024

View reviewed changes

api/v1/helper.go Outdated Show resolved Hide resolved

adrianchiris reviewed Jan 29, 2024

View reviewed changes

api/v1/sriovnetworknodestate_types.go Outdated Show resolved Hide resolved

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from edcd15e to b30ab24 Compare May 8, 2024 10:36

adrianchiris reviewed May 8, 2024

View reviewed changes

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from b30ab24 to 83c8397 Compare May 8, 2024 16:08

adrianchiris approved these changes May 9, 2024

View reviewed changes

zeeke reviewed May 9, 2024

View reviewed changes

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 83c8397 to 0ecd227 Compare May 10, 2024 08:26

adrianchiris approved these changes May 13, 2024

View reviewed changes

SchSeba reviewed May 22, 2024

View reviewed changes

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 0ecd227 to 5f8d1a1 Compare May 23, 2024 10:30

Move constants to pkg and add IsLinkAdminStateUp in netlinklib

5f3c4e9

Signed-off-by: Vasilis Remmas <[email protected]>

vasrem force-pushed the fix/enhance-checks-on-generic-plugin branch from 5f8d1a1 to 5f3c4e9 Compare May 23, 2024 10:50

adrianchiris approved these changes May 23, 2024

View reviewed changes

SchSeba approved these changes May 23, 2024

View reviewed changes

SchSeba merged commit 8d32f42 into k8snetworkplumbingwg:master May 23, 2024
12 checks passed

vasrem deleted the fix/enhance-checks-on-generic-plugin branch May 27, 2024 11:55

zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jun 25, 2024

Fix undefined: pciAddr

ebdf4c5

Merge issue coming from - k8snetworkplumbingwg#690 - k8snetworkplumbingwg#587 Signed-off-by: Andrea Panattoni <[email protected]>

zeeke mentioned this pull request Jun 25, 2024

Fix undefined: pciAddr #724

Merged

zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jun 25, 2024

Fix undefined: pciAddr

c7c1edb

Merge issue coming from - k8snetworkplumbingwg#690 - k8snetworkplumbingwg#587 Signed-off-by: Andrea Panattoni <[email protected]>

maze88 pushed a commit to Mellanox/sriov-network-operator that referenced this pull request Jul 2, 2024

Fix undefined: pciAddr

9d53c18

Merge issue coming from - k8snetworkplumbingwg#690 - k8snetworkplumbingwg#587 Signed-off-by: Andrea Panattoni <[email protected]>

rollandf pushed a commit to rollandf/sriov-network-operator that referenced this pull request Jan 15, 2025

Fix undefined: pciAddr

d023a99

Merge issue coming from - k8snetworkplumbingwg#690 - k8snetworkplumbingwg#587 Signed-off-by: Andrea Panattoni <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more checks on generic plugin to discover discrepancies from the desired state #587

Add more checks on generic plugin to discover discrepancies from the desired state #587

vasrem commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

coveralls commented Jan 17, 2024 •

edited

Loading

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

vasrem commented Jan 19, 2024

github-actions bot commented Jan 19, 2024

github-actions bot commented Jan 29, 2024

vasrem commented Jan 29, 2024

github-actions bot commented May 8, 2024

adrianchiris May 8, 2024

vasrem May 8, 2024

adrianchiris left a comment •

edited

Loading

github-actions bot commented May 8, 2024

zeeke May 9, 2024

vasrem May 10, 2024

github-actions bot commented May 10, 2024

adrianchiris commented May 13, 2024

vasrem commented May 21, 2024

SchSeba left a comment

SchSeba May 22, 2024

SchSeba May 22, 2024

SchSeba May 22, 2024

github-actions bot commented May 23, 2024

vasrem commented May 23, 2024

github-actions bot commented May 23, 2024

SchSeba left a comment

	func (n *network) GetNetDevMac(ifaceName string) string {
	log.Log.V(2).Info("GetNetDevMac(): get Mac", "device", ifaceName)
	macFilePath := filepath.Join(vars.FilesystemRoot, consts.SysClassNet, ifaceName, "address")
	data, err := os.ReadFile(macFilePath)
	if err != nil {
	log.Log.Error(err, "GetNetDevMac(): fail to read Mac file", "path", macFilePath)
	return ""
	}

	return strings.TrimSpace(string(data))
	}

	func (s *sriov) GetLinkType(ifaceStatus sriovnetworkv1.InterfaceExt) string {
	log.Log.V(2).Info("GetLinkType()", "device", ifaceStatus.PciAddress)
	if ifaceStatus.Name != "" {
	link, err := netlink.LinkByName(ifaceStatus.Name)
	if err != nil {
	log.Log.Error(err, "GetLinkType(): failed to get link", "device", ifaceStatus.Name)
	return ""
	}
	linkType := link.Attrs().EncapType
	if linkType == "ether" {
	return consts.LinkTypeETH
	} else if linkType == "infiniband" {
	return consts.LinkTypeIB
	}
	}

	return ""
	}

Add more checks on generic plugin to discover discrepancies from the desired state #587

Add more checks on generic plugin to discover discrepancies from the desired state #587

Conversation

vasrem commented Jan 17, 2024 • edited Loading

Summary

Partial Reconciliation

Decisions

Open questions

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

coveralls commented Jan 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9206688050

Details

💛 - Coveralls

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 18, 2024

vasrem commented Jan 19, 2024

github-actions bot commented Jan 19, 2024

github-actions bot commented Jan 29, 2024

vasrem commented Jan 29, 2024

github-actions bot commented May 8, 2024

adrianchiris May 8, 2024

Choose a reason for hiding this comment

vasrem May 8, 2024

Choose a reason for hiding this comment

adrianchiris left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024

zeeke May 9, 2024

Choose a reason for hiding this comment

vasrem May 10, 2024

Choose a reason for hiding this comment

github-actions bot commented May 10, 2024

adrianchiris commented May 13, 2024

vasrem commented May 21, 2024

SchSeba left a comment

Choose a reason for hiding this comment

SchSeba May 22, 2024

Choose a reason for hiding this comment

SchSeba May 22, 2024

Choose a reason for hiding this comment

SchSeba May 22, 2024

Choose a reason for hiding this comment

github-actions bot commented May 23, 2024

vasrem commented May 23, 2024

github-actions bot commented May 23, 2024

SchSeba left a comment

Choose a reason for hiding this comment

vasrem commented Jan 17, 2024 •

edited

Loading

coveralls commented Jan 17, 2024 •

edited

Loading

adrianchiris left a comment •

edited

Loading