[switchdev 2/x] API: Add vdpaType field to the node SriovNetworkNodeState CRD #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field should be used to report information about type of the VDPA device that is configured for VF. Empty string means that there is no VDPA device. Valid values are: `virtio`, `vhost` (same as in `SriovNetworkNodePolicySpec`) Signed-off-by: Yury Kulazhenkov <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 7476081547
💛 - Coveralls |
ykulazhenkov
changed the title
| @@ -82,6 +82,7 @@ type VirtualFunction struct { | |||
| Vlan int `json:"Vlan,omitempty"` | |||
| Mtu int `json:"mtu,omitempty"` | |||
| VfID int `json:"vfID"` | |||
| VdpaType string `json:"vdpaType,omitempty"` | |||
There was a problem hiding this comment.
i guess we should hold off merging this until we got some logic to populate this field ?
There was a problem hiding this comment.
I will submit commits which relies on this change soon. Also this field is a part of internal API which is used only by the operator itself.
adrianchiris
approved these changes
Jan 17, 2024
zeeke
approved these changes
Jan 23, 2024
zeeke
added a commit
to zeeke/sriov-network-operator
that referenced
this pull request
Feb 1, 2024
Aligned field `SriovNetworkNodeState.Status.Interfaces.Vfs.VdpaType` Refs: - k8snetworkplumbingwg/sriov-network-operator#583 Signed-off-by: Andrea Panattoni <[email protected]>
SchSeba
pushed a commit
to SchSeba/sriov-network-operator
that referenced
this pull request
May 7, 2024
Aligned field `SriovNetworkNodeState.Status.Interfaces.Vfs.VdpaType` Refs: - k8snetworkplumbingwg/sriov-network-operator#583 Signed-off-by: Andrea Panattoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field should be used to report information about type of the VDPA device that is configured for VF.
Empty string means that there is no VDPA device.
Valid values are:
virtio,vhost(same as inSriovNetworkNodePolicySpec)Context: