Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm chart kubeVersion check #576

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

ianb-mp
Copy link
Contributor

@ianb-mp ianb-mp commented Jan 8, 2024

Change the kubeVersion constraint to permit pre-release versions as per: https://helm.sh/docs/chart_template_guide/function_list/#working-with-prerelease-versions

Without this change, if I attempt to install the helm chart into k8s version v1.27.1-3443+19254894103e33-dirty I see this error:

Error: INSTALLATION FAILED: chart requires kubeVersion: >= 1.16.0 which is incompatible with Kubernetes v1.27.1-3443+19254894103e33-dirty

Copy link

github-actions bot commented Jan 8, 2024

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7441852067

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 25.683%

Totals Coverage Status
Change from base Build 7394863285: -0.06%
Covered Lines: 2358
Relevant Lines: 9181

💛 - Coveralls

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine with me.

@adrianchiris adrianchiris merged commit b393f30 into k8snetworkplumbingwg:master Jan 8, 2024
@ianb-mp ianb-mp deleted the patch-2 branch January 8, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants