Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image build target additions #563

Merged
merged 1 commit into from
Dec 31, 2023
Merged

image build target additions #563

merged 1 commit into from
Dec 31, 2023

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Dec 25, 2023 •
edited
Loading

  • Add webhook to image build target
  • use APP_NAME var in image name for consistency

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Dec 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7338261669

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.651%
Totals Coverage Status
Change from base Build 7280777027: 0.0%
Covered Lines: 2354
Relevant Lines: 9177
💛 - Coveralls

@adrianchiris
image build target additions
a608580 
- Add webhook to image build target
- use APP_NAME var in image name for consistency

Signed-off-by: adrianc <[email protected]>
@adrianchiris adrianchiris force-pushed the add-webhook-image-target branch from 4097281 to a608580 Compare December 27, 2023 12:24
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris changed the title Add webhook to image build target image build target additions Dec 27, 2023
@adrianchiris adrianchiris requested a review from SchSeba December 27, 2023 12:25
@adrianchiris adrianchiris mentioned this pull request Dec 27, 2023
Closed
@adrianchiris
Copy link
Collaborator Author

@SchSeba @zeeke PTAL

@adrianchiris adrianchiris requested a review from zeeke December 27, 2023 16:50
vasrem
vasrem reviewed Dec 28, 2023
View reviewed changes
Makefile Show resolved Hide resolved
SchSeba
SchSeba approved these changes Dec 31, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit 858a9b3 into k8snetworkplumbingwg:master Dec 31, 2023
11 checks passed
@adrianchiris adrianchiris deleted the add-webhook-image-target branch July 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasrem vasrem vasrem left review comments

@SchSeba SchSeba SchSeba approved these changes

@zeeke zeeke Awaiting requested review from zeeke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchiris @coveralls @SchSeba @vasrem