Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error overwrite for setSriovNumVfs #548

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

mlguerrero12
Copy link
Contributor

When setSriovNumVfs fails, the error is overwritten by the return error of RemoveUdevRule. If the latter function doesn't return an error (most cases), the reconciliation loop will report success even if vfs were not created/configured.

Issue found while trying to run the operator on a node that didn't have sriov enabled on the bios.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
When setSriovNumVfs fails, the error is overwritten by the return
error of RemoveUdevRule. If the latter function doesn't return an
error (most cases), the reconciliation loop will report success even
if vfs were not created/configured.
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6903534373

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 25.464%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 70.45%
Totals Coverage Status
Change from base Build 6848351544: 0.09%
Covered Lines: 2334
Relevant Lines: 9166

💛 - Coveralls

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for fixing this!

@zeeke zeeke merged commit 6445d38 into k8snetworkplumbingwg:master Nov 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants