Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs sriov-network-config-daemon by default #545

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Logs sriov-network-config-daemon by default #545

merged 1 commit into from
Nov 21, 2023

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Nov 10, 2023

Container sriov-network-config-daemon in the daemonset is the most interesting in the list. Make kubectl logs ... target that by default.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Nov 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6849330622

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 25.355%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 68.94%
Totals Coverage Status
Change from base Build 6848351544: -0.02%
Covered Lines: 2324
Relevant Lines: 9166
💛 - Coveralls

SchSeba
SchSeba approved these changes Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only have one running container so it should be the default but I don't see a problem adding this annotation

adrianchiris
adrianchiris reviewed Nov 12, 2023
View reviewed changes
bindata/manifests/daemon/daemonset.yaml Outdated
@@ -21,6 +21,8 @@ spec:
component: network
type: infra
openshift.io/component: network
annotations:
kubectl.kubernetes.io/default-logs-container: sriov-network-config-daemon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is deprecated: https://kubernetes.io/docs/reference/labels-annotations-taints/#kubectl-kubernetes-io-default-logs-container-deprecated

please use : kubectl.kubernetes.io/default-container

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that. fixed

adrianchiris
adrianchiris requested changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current annot is deprecated

@zeeke zeeke force-pushed the daemon-default-container branch from 5c2bf0c to 76d44a5 Compare November 13, 2023 09:15
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke
Copy link
Member Author

zeeke commented Nov 13, 2023

we only have one running container so it should be the default but I don't see a problem adding this annotation

@SchSeba you're right, we have only one non-init container running and kubectl takes the first Spec field:

https://github.com/kubernetes/kubectl/blob/6a876632fa1b55560c6efd3d946de7a21f0d504d/pkg/polymorphichelpers/logsforobject.go#L98

Since the introduction of systemd mode, sriov-cni and sriov-infiniband-cni containers have been moved to Spec.InitContainers, which are not taken into consideration when getting the default container to log.

This PR has no actual impact on the upstream operator's behavior.
I'm fine with closing it

@zeeke
Logs sriov-network-config-daemon by default
0f17753 
Container `sriov-network-config-daemon` in the daemonset
is the most interesting in the list. Make `kubectl logs ...` target
that by default.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the daemon-default-container branch from 76d44a5 to 0f17753 Compare November 13, 2023 11:27
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke zeeke requested a review from adrianchiris November 13, 2023 15:36
@adrianchiris adrianchiris merged commit dadaa89 into k8snetworkplumbingwg:master Nov 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeeke @coveralls @SchSeba @adrianchiris