Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add cluster-info as job artifact #534

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Oct 30, 2023

Use kubectl cluster-info dump to retrieve useful debug information at the end of the end-to-end test run.

@zeeke zeeke changed the title e2e: Add cluster-info as job artifact e2e: Add cluster-info as job artifact Oct 30, 2023
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

SUITE=./test/conformance JUNIT_OUTPUT=`pwd`/k8s-artifacts hack/run-e2e-conformance.sh

if [[ -v TEST_REPORT_PATH ]]; then
JUNIT_OUTPUT="${TEST_REPORT_PATH}/conformance-test-report"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is pwd not longer needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch: relative paths are relatives to the test suite entrypoint, i.e. test/conformance/test_suite_test.go

@zeeke zeeke force-pushed the e2e-debug-archive branch from 0464982 to a647ec8 Compare October 31, 2023 09:54
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@mlguerrero12
Copy link
Contributor

LGTM

@zeeke
Copy link
Member Author

zeeke commented Oct 31, 2023

/hold

artifact archives does not contains junit XML report and failure folder (there should be at least an empty folder)
https://github.com/k8snetworkplumbingwg/sriov-network-operator/actions/runs/6704825113?pr=534

@github-actions github-actions bot added the hold label Oct 31, 2023
@zeeke zeeke force-pushed the e2e-debug-archive branch from a647ec8 to bfd009f Compare October 31, 2023 11:19
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke
Copy link
Member Author

zeeke commented Oct 31, 2023

/unhold

export JUNIT_OUTPUT=... was missing

Use `kubectl cluster-info dump` to retrieve useful
debug information at the end of the end-to-end test run.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke force-pushed the e2e-debug-archive branch from bfd009f to 50fcaf3 Compare October 31, 2023 11:20
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6705768745

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 25.558%

Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 70.45%
controllers/sriovnetwork_controller.go 2 72.18%
Totals Coverage Status
Change from base Build 6704865825: -0.02%
Covered Lines: 2334
Relevant Lines: 9132

💛 - Coveralls

@zeeke zeeke removed the hold label Oct 31, 2023
@zeeke
Copy link
Member Author

zeeke commented Nov 3, 2023

Got 3 LGTM from 2 different vendors, merging

@zeeke zeeke merged commit e35bc9e into k8snetworkplumbingwg:master Nov 3, 2023
11 checks passed
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Nov 3, 2023
This is a leftover from
- k8snetworkplumbingwg#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Nov 3, 2023
This is a leftover from
- k8snetworkplumbingwg#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jan 23, 2024
This is a leftover from
- k8snetworkplumbingwg#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jan 23, 2024
This is a leftover from
- k8snetworkplumbingwg#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
zeeke added a commit to zeeke/sriov-network-operator-1 that referenced this pull request Jan 29, 2024
This is a leftover from
- k8snetworkplumbingwg#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request May 7, 2024
This is a leftover from
- k8snetworkplumbingwg/sriov-network-operator#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request May 25, 2024
This is a leftover from
- k8snetworkplumbingwg/sriov-network-operator#534

Prior to this commit, `kubectl cluster-info ...` is invoked
only if the conformance tests does not fail, which is not
that useful.

Signed-off-by: Andrea Panattoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants