-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Add cluster-info
as job artifact
#534
Conversation
cluster-info
as job artifact
Thanks for your PR,
To skip the vendors CIs use one of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
SUITE=./test/conformance JUNIT_OUTPUT=`pwd`/k8s-artifacts hack/run-e2e-conformance.sh | ||
|
||
if [[ -v TEST_REPORT_PATH ]]; then | ||
JUNIT_OUTPUT="${TEST_REPORT_PATH}/conformance-test-report" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is pwd
not longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch: relative paths are relatives to the test suite entrypoint, i.e. test/conformance/test_suite_test.go
0464982
to
a647ec8
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
LGTM |
/hold artifact archives does not contains junit XML report and failure folder (there should be at least an empty folder) |
a647ec8
to
bfd009f
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
/unhold
|
Use `kubectl cluster-info dump` to retrieve useful debug information at the end of the end-to-end test run. Signed-off-by: Andrea Panattoni <[email protected]>
bfd009f
to
50fcaf3
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6705768745
💛 - Coveralls |
Got 3 LGTM from 2 different vendors, merging |
This is a leftover from - k8snetworkplumbingwg#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg/sriov-network-operator#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
This is a leftover from - k8snetworkplumbingwg/sriov-network-operator#534 Prior to this commit, `kubectl cluster-info ...` is invoked only if the conformance tests does not fail, which is not that useful. Signed-off-by: Andrea Panattoni <[email protected]>
Use
kubectl cluster-info dump
to retrieve useful debug information at the end of the end-to-end test run.