Increase end-to-end test coverage #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6796186050
💛 - Coveralls |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
andreaskaris
suggested changes
Oct 26, 2023
| @@ -108,7 +108,7 @@ var _ = Describe("[sriov] operator", func() { | |||
| Describe("No SriovNetworkNodePolicy", func() { | |||
| Context("SR-IOV network config daemon can be set by nodeselector", func() { | |||
| // 26186 | |||
| FIt("Should schedule the config daemon on selected nodes", func() { | |||
| It("Should schedule the config daemon on selected nodes", func() { | |||
There was a problem hiding this comment.
I don't want to be pedantic but instead of FIt in the previous commit and then moving it back to It it in this commit, wouldn't it be better to rebase and make sure that it's always It in both commits?
There was a problem hiding this comment.
sure, it's better to make it clean
Add a basic assertion in the end-to-end suite to verify that the config-daemon is able to publish k8s Events. Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
From my side (sriov logging) lgtm |
mlguerrero12
reviewed
Nov 8, 2023
Add an end-to-end test to verify that configuring the LogLevel field of a SriovNetwork makes sriov cni Add command logging to multus pods Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Nov 9, 2023
|
LGTM |
SchSeba
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic assertion in the end-to-end suite to
verify that the config-daemon can publish
k8s Events.
cc @rollandf
Add an end-to-end test to verify that configuring the LogLevel
field of a SriovNetwork makes sriov cni Add command logging
to multus pods
cc @andreaskaris