-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vlanProto parameter #517
Add vlanProto parameter #517
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
9838b76
to
3bf347f
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
3bf347f
to
26e8fe7
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6431474589
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like failing github actions are not related to this PR, as they fail in other PRs as well
yes, we need to merge the fix in sriov-cni |
Thanks for your PR,
To skip the vendors CIs use one of:
|
@adrianchiris, @SchSeba, could you please have a look at this? It's for the recently added vlanProto parameter. Thanks. |
The sriov-cni has a new parameter to set the vlan protocol assign to the vf. Signed-off-by: Marcelo Guerrero <[email protected]>
26e8fe7
to
bcfa74a
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
@Eoghan1232, could you please have a look at this? It's for the recent vlanProto parameter we added in sriov-cni. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
merging with 2 approvals. |
The sriov-cni has a new parameter to set the vlan protocol assign to the vf.