improve github actions #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Can you change the commit message to: |
SchSeba
force-pushed
the
update_github_actions
branch
from
7bee133 to
1a9b709
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
1a9b709 to
1f5dfaa
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
LGTM |
|
/hold |
SchSeba
force-pushed
the
update_github_actions
branch
from
1f5dfaa to
3576111
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 6422033325
💛 - Coveralls |
SchSeba
force-pushed
the
update_github_actions
branch
from
3576111 to
21cd829
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
21cd829 to
52e81c0
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
I moved the virtual cluster to the same file as the build and unit test so we can have a dependency. |
|
/hold cancel |
SchSeba
force-pushed
the
update_github_actions
branch
from
52e81c0 to
c89dfc1
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
c89dfc1 to
c45cf80
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
c45cf80 to
c5770d0
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
1 similar comment
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
- Require short running actions (golangci, test, build) before starting slower virtual-k8s-cluster and only run virtual-ocp when virtual-k8s-cluster succeed - Allow cancellation These two changes together reduce the amount of resources used Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
update_github_actions
branch
from
fcc9137 to
f2489bb
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
f2489bb to
8bf9d47
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
reviewed
Oct 3, 2023
| @@ -130,18 +130,67 @@ kcli ssh $cluster_name-ctlplane-0 << EOF | |||
| sudo su | |||
| echo '$insecure_registry' > /etc/containers/registries.conf.d/003-internal.conf | |||
| systemctl restart crio | |||
|
|
|||
| echo '[connection] | |||
There was a problem hiding this comment.
nit: define function and call it for each node ?
e0ne
approved these changes
Oct 5, 2023
SchSeba
force-pushed
the
update_github_actions
branch
from
8bf9d47 to
3cc8117
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
3cc8117 to
cd17b4a
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
cd17b4a to
3996f73
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
force-pushed
the
update_github_actions
branch
from
3996f73 to
d54293f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
disable dhcp on vfs for vanilly k8s CI. if we don't disable it the device plugin will not use this devices Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
update_github_actions
branch
from
d54293f to
41774fb
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add cancel on progress and also run the virtual cluster tests only if all the light lanes like build and unit tests pass to save resources