New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused VERSION variable and accidentally added file #503

Merged

adrianchiris merged 2 commits into k8snetworkplumbingwg:master from bn222:master

Sep 11, 2023

Collaborator

bn222 commented Sep 11, 2023

No description provided.

bn222 added 2 commits

September 8, 2023 15:01


          Remove unused VERSION variable

7572c87


          Remove file that got added accidently

ded9eca

Signed-off-by: Balazs Nemeth <[email protected]>

github-actions bot commented Sep 11, 2023

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls commented Sep 11, 2023

Pull Request Test Coverage Report for Build 6144215578

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 25.416%

Totals
Change from base Build 6121359042:	0.05%
Covered Lines:	2123
Relevant Lines:	8353

💛 - Coveralls

Collaborator Author

bn222 commented Sep 11, 2023

@e0ne PTAL. Forgot this from the previous PR.

zeeke approved these changes

View reviewed changes

Member

zeeke left a comment

config/manifests/bases/sriov-network-operator.clusterserviceversion.yaml and config/manifests/kustomization.yaml were accidentally added here

Update golang.org/x/net/html #499

They are useful in downstream repo only https://github.com/openshift/sriov-network-operator

LGTM

adrianchiris approved these changes

View reviewed changes

adrianchiris merged commit 7c2116e into k8snetworkplumbingwg:master

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet