Use e2e-test tag for images built in e2e CI
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for the kind CI, Kind deploys Kubernetes version v1.27.3, in this version the `ImagePullpolicy` of containers follow the procedures in [1], this breaks the CI, since the CI uses the `latest` tag when building the images, and Kubernetes tries to pull the images always instead of using the built image. This patch changes the tag of the image built by CI to `e2e-test`, so that K8S will set the image policy to be `IfNotPresent`. [1] https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting Signed-off-by: Abdallah Yasin <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 5505729041
💛 - Coveralls |
|
/test-e2e-nvidia-all |
|
@e0ne @adrianchiris Can you guys PTAL? |
|
/test-e2e-nvidia-all |
e0ne
approved these changes
Jul 10, 2023
|
as the images for e2e tests are built by the alternative is to explicitly add image pull policy when running make deploy. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for the kind CI, Kind deploys Kubernetes version v1.27.3, in this version the
ImagePullpolicyof containers follow the procedures in [1], this breaks the CI, since the CI uses thelatesttag when building the images, and Kubernetes tries to pull the images always instead of using the built image.This patch changes the tag of the image built by CI to
e2e-test, so that K8S will set the image policy to beIfNotPresent.[1] https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting