-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externally manage e2e tests #460
Closed
SchSeba
wants to merge
7
commits into
k8snetworkplumbingwg:master
from
SchSeba:externally_manage_tests
Closed
Externally manage e2e tests #460
SchSeba
wants to merge
7
commits into
k8snetworkplumbingwg:master
from
SchSeba:externally_manage_tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit add the new API allow the operator to use virtual functions that the user configure manually on the system this will allow new use-cases like using a VF as the SDN primary nic. the nic will be created before the operator start by the user, for example using nmstate or NetworkManager and the operator will allocate all the remaining vfs to pods. Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
this commit adds the functionality needed to save the PF information into the host. we need this in case the user removes a policy that was externallyCreated. we must NOT delete reset the VFs in that case and the only way to know that the device was externallyCreated after the user removes the policy is to check this file on the host. Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 5312729357
💛 - Coveralls |
Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
externally_manage_tests
branch
from
June 19, 2023 13:53
16b2289
to
46b15e6
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
I put the tests in the same PR closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e tests for #436