Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externally manage e2e tests #460

Closed

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Jun 19, 2023

e2e tests for #436

SchSeba added 6 commits June 14, 2023 14:10
this commit add the new API allow the operator to use virtual functions
that the user configure manually on the system

this will allow new use-cases like using a VF as the SDN primary nic.
the nic will be created before the operator start by the user, for
example using nmstate or NetworkManager and the operator will allocate
all the remaining vfs to pods.

Signed-off-by: Sebastian Sch <[email protected]>
this commit adds the functionality needed to save the PF information
into the host.
we need this in case the user removes a policy that was
externallyCreated.

we must NOT delete reset the VFs in that case and the only way to know
that the device was externallyCreated after the user removes the policy
is to check this file on the host.

Signed-off-by: Sebastian Sch <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jun 19, 2023

Pull Request Test Coverage Report for Build 5312729357

  • 23 of 190 (12.11%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 25.592%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/writer.go 0 1 0.0%
pkg/plugins/mellanox/mellanox_plugin.go 0 3 0.0%
pkg/webhook/validate.go 17 23 73.91%
api/v1/helper.go 0 7 0.0%
pkg/daemon/daemon.go 5 13 38.46%
pkg/plugins/generic/generic_plugin.go 0 15 0.0%
pkg/utils/utils.go 1 49 2.04%
pkg/utils/host.go 0 79 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/utils/utils.go 2 7.47%
Totals Coverage Status
Change from base Build 5268039487: -0.2%
Covered Lines: 1989
Relevant Lines: 7772

💛 - Coveralls

@SchSeba SchSeba force-pushed the externally_manage_tests branch from 16b2289 to 46b15e6 Compare June 19, 2023 13:53
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Aug 6, 2023

I put the tests in the same PR closing this one

#436

@SchSeba SchSeba closed this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants