Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes in e2e test to run on single node #446

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented May 25, 2023

on single node the drain is disable so on the last test we must clean the pods.

we don't use AfterEach because it's not possible to run a reporter on that.

on single node the drain is disable so on the last test we must clean
the pods.

we don't use AfterEach because it's not possible to run a reporter on that.

Signed-off-by: Sebastian Sch <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5079690361

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 25.592%

Totals Coverage Status
Change from base Build 5022019978: 0.03%
Covered Lines: 1933
Relevant Lines: 7553

💛 - Coveralls

@liornoy
Copy link
Contributor

liornoy commented May 31, 2023

are the changes to the timeout (from 1 to 3 and from 3 to 5) required due to re-occurring flakes?

@SchSeba
Copy link
Collaborator Author

SchSeba commented Jun 1, 2023

@liornoy right SNO have high CPU load and stuff may take a bit more time then expected

@liornoy
Copy link
Contributor

liornoy commented Jun 1, 2023

cool. lgtm

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeeke zeeke merged commit 109c2c2 into k8snetworkplumbingwg:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants