Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a costume junit reporter to the conformance suite #440

Merged
merged 2 commits into from
May 19, 2023
Merged

Add a costume junit reporter to the conformance suite #440

merged 2 commits into from
May 19, 2023

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented May 15, 2023

Currently, the conformance test can be invoked with ginkgo's --junit-report
flag and produce a default junit report.

This commit adds a non-default junit report to the conformance suite
and configures it with specific configurations to produce
clean and easy-to-read report.

Added a "junit" flag, that when is not empty, will
produce the junit report in the given path, with the
report name "junit_sriov_conformance.xml"

liornoy added 2 commits May 15, 2023 15:18
This commit bumps ginkgo's version to v2.9.4
in order to have the required junit configurations.
Specifically the: OmitLeafNodeType and OmitSuiteSetupNodes options.

Signed-off-by: liornoy <[email protected]>
Currently, the conformance test can be invoked with ginkgo's --junit-report
flag and produce a default junit report.

This commit adds a non-default junit report to the conformance suite
and configures it with specific configurations to produce
clean and easy to read report.

Added a "junit" flag, that when is not empty, it will
produce the junit report in the given path, with the
report name of "junit_sriov_conformance.xml"

Signed-off-by: liornoy <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4980300528

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 25.54%

Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 66.04%
controllers/sriovnetwork_controller.go 2 63.81%
api/v1/helper.go 6 41.32%
Totals Coverage Status
Change from base Build 4843162397: -0.1%
Covered Lines: 1929
Relevant Lines: 7553

💛 - Coveralls

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @liornoy

@zeeke zeeke merged commit 1c6e1b3 into k8snetworkplumbingwg:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants