Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put sriov-network-config-daemon contianer on the first place #426

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Mar 28, 2023

Make sriov-network-config-daemon container as a default to access logs easier without specifing container name. It's more often use-case rather then checking CNIs logs.

Make sriov-network-config-daemon container as a default to access
logs easier without specifing container name. It's more often
use-case rather then checking CNIs logs.
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4542920865

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 25.513%

Files with Coverage Reduction New Missed Lines %
api/v1/helper.go 3 41.32%
controllers/sriovnetwork_controller.go 6 61.9%
Totals Coverage Status
Change from base Build 4502357889: -0.1%
Covered Lines: 1927
Relevant Lines: 7553

💛 - Coveralls

@tariq1890
Copy link
Contributor

tariq1890 commented Apr 2, 2023

Instead of re-ordering the container part in the manifest, you can set the annotation to specify which container to default to when executing kubectl log/port-forward.

kubectl.kubernetes.io/default-container

@adrianchiris
Copy link
Collaborator

Thanks @e0ne !

im fine with both approaches (annot as @tariq1890 mentioned or reorder containers).

current approach ultimately ends up in fewer lines of text so thats a plus :) while the other is explicit so its clear what logs we are getting by default.

@adrianchiris adrianchiris merged commit 344313f into k8snetworkplumbingwg:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants