Add the no-wait argument to ovs-vsctl commands for hw-offload #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "no-wait" argument is needed for ovs-vsctl commands because there is a chance for ovs-vsctl to timeout. Adding "--no-wait" to the command line would make it such that ovs-vsctl doesn't wait for ovs-vswitchd to update "cur_cfg" An example of this timeout is shown here: ovs-vsctl[3265]: ovs|00001|vsctl|INFO|Called as /bin/ovs-vsctl set Open_vSwitch . other_config:hw-offload=true systemd[1]: ovs-vswitchd.service: start-pre operation timed out. Terminating. ovs-vsctl[3265]: 2023-02-22T22:00:20Z|00002|fatal_signal|WARN|terminating with signal 15 (Terminated) ovs-vsctl[3265]: ovs|00002|fatal_signal|WARN|terminating with signal 15 (Terminated) systemd[1]: ovs-vswitchd.service: Failed with result 'timeout'. systemd[1]: Failed to start Open vSwitch Forwarding Unit.
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/cc @bn222 |
Pull Request Test Coverage Report for Build 4378389223
💛 - Coveralls |
|
This is a great find. Thanks for figuring this one out. I like the idea of adding no-wait we avoid a timeout from systemd. However, I'm wondering what other implications this has. Afaict, not waiting to finish setting hwol to true isn't going to have an impact elsewhere. /lgtm |
adrianchiris
approved these changes
Mar 13, 2023
|
@wizhaoredhat Is this the fix to the ovs-configuration service failure you found on openshift 4.13? |
Yes it was in OCP 4.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "no-wait" argument is needed for ovs-vsctl commands because there is a chance for ovs-vsctl to timeout.
Adding "--no-wait" to the command line would make it such that ovs-vsctl doesn't wait for ovs-vswitchd to update "cur_cfg"
An example of this timeout is shown here:
ovs-vsctl[3265]: ovs|00001|vsctl|INFO|Called as /bin/ovs-vsctl set Open_vSwitch . other_config:hw-offload=true systemd[1]: ovs-vswitchd.service: start-pre operation timed out. Terminating. ovs-vsctl[3265]: 2023-02-22T22:00:20Z|00002|fatal_signal|WARN|terminating with signal 15 (Terminated) ovs-vsctl[3265]: ovs|00002|fatal_signal|WARN|terminating with signal 15 (Terminated) systemd[1]: ovs-vswitchd.service: Failed with result 'timeout'. systemd[1]: Failed to start Open vSwitch Forwarding Unit.