New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sriov-network-config-daemon crash when nodeInfo cannot be obtained #415

Merged

zeeke merged 1 commit into k8snetworkplumbingwg:master from lizhewei91:no-nodeInfo-crash

Mar 21, 2023

lizhewei91 commented Mar 7, 2023

Change the error level of nodeinfo from warning to fatal. If error is not empty, config-daemon crash. #414


          Make sriov-network-config-daemon crash when nodeInfo cannot be obtained

f6346e2

github-actions bot commented Mar 7, 2023

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

Author

lizhewei91 commented Mar 7, 2023

/test-all

adrianchiris approved these changes

View reviewed changes

Collaborator

adrianchiris commented Mar 12, 2023

/test-all

coveralls commented Mar 12, 2023

Pull Request Test Coverage Report for Build 4353945761

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 25.727%

Files with Coverage Reduction	New Missed Lines	%
api/v1/helper.go	3	41.92%

Totals
Change from base Build 4301504699:	-0.04%
Covered Lines:	1946
Relevant Lines:	7564

💛 - Coveralls

Collaborator

adrianchiris commented Mar 21, 2023

@zeeke mind giving this one a quick review ?

zeeke approved these changes

View reviewed changes

Member

zeeke left a comment

/lgtm sorry for the late review.

zeeke merged commit 86db37e into k8snetworkplumbingwg:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet