Update support for operator deployment on PSA #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/cc @bn222 PTAL |
PR k8snetworkplumbingwg#371 provided changes to allow the deployment of the operator when PSA is enabled. https://kubernetes.io/docs/concepts/security/pod-security-admission/ This commit provides minor updates to address comments on the previous PR. Signed-off-by: Salvatore Daniele <[email protected]> Co-authored-by: Sebastian Sch <[email protected]>
SalDaniele
force-pushed
the
update_PSA_support_fix
branch
from
a027cfb to
664b363
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/lgtm |
adrianchiris
approved these changes
Feb 15, 2023
|
Hi @wizhaoredhat this works for OCP without the other label to disable the OCP sync? |
Pull Request Test Coverage Report for Build 4174425076
💛 - Coveralls |
|
Hi @SchSeba when testing on my OCP cluster I did not need to include 'security.openshift.io/scc.podSecurityLabelSync: "false"' Perhaps this is already disabled for openshift-sriov-network-operator by default [1]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #371 provided changes to allow the deployment of the operator when PSA is enabled.
https://kubernetes.io/docs/concepts/security/pod-security-admission/
This commit provides minor updates to address comments on the previous PR.
Signed-off-by: Salvatore Daniele [email protected]
Co-authored-by: Sebastian Sch [email protected]