Pretty print CNI config when rendering NetAttachDefs #406

tariq1890 · 2023-02-08T13:47:49Z

When debugging CNI configs, it becomes a lot easier when we can see pretty-printed JSON in NetworkAttachmentDefinitions

github-actions · 2023-02-08T13:48:03Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2023-02-08T13:56:30Z

Pull Request Test Coverage Report for Build 4433914725

8 of 16 (50.0%) changed or added relevant lines in 3 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 25.45%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/helper.go	4	6	66.67%
controllers/sriovibnetwork_controller.go	2	5	40.0%
controllers/sriovnetwork_controller.go	2	5	40.0%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovnetwork_controller.go	2	65.71%
test/util/util.go	4	39.73%

Totals
Change from base Build 4418252967:	-0.2%
Covered Lines:	1921
Relevant Lines:	7548

💛 - Coveralls

tariq1890 · 2023-02-09T06:40:53Z

@adrianchiris @SchSeba @e0ne

Request review on this as well

api/v1/helper.go

tariq1890 · 2023-03-01T15:46:38Z

@adrianchiris Any update on this?

github-actions · 2023-03-10T20:28:09Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-10T20:29:54Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-11T18:32:11Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

tariq1890 · 2023-03-11T18:46:15Z

@adrianchiris I have updated the PR to ensure the rendered CNI config in the NetAttachDef is pretty-printed. Requesting your review on this

adrianchiris · 2023-03-12T07:21:01Z

/test-all

controllers/sriovibnetwork_controller.go

controllers/sriovnetwork_controller.go

github-actions · 2023-03-13T02:25:18Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-13T02:48:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

tariq1890 · 2023-03-13T03:08:39Z

/test-all

test/util/util.go

github-actions · 2023-03-13T17:18:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-13T17:19:04Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-13T17:21:21Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

zeeke

/lgtm

@tariq1890 thanks for working on this

waiting for @adrianchiris approval as the code changed a bit since his last review

controllers/helper.go

controllers/sriovibnetwork_controller_test.go

controllers/sriovnetwork_controller_test.go

github-actions · 2023-03-14T15:24:32Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-16T05:26:51Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-03-16T05:32:51Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

tariq1890 · 2023-03-16T05:33:34Z

@adrianchiris I have split the commits into two. Please re-review

adrianchiris · 2023-03-16T07:24:51Z

lets get inputs from @SchSeba @fedepaol regarding the moved methods, i dont remember if these are used in a CI/testing proj in Openshift.

other than that im LGTM

zeeke · 2023-03-16T11:13:19Z

I can confirm that methods GenerateExpectedNetConfig and GenerateExpectedIBNetConfig are not used by Openshift testing project:

https://github.com/openshift-kni/cnf-features-deploy/tree/master/cnf-tests/testsuites

I asked @tariq1890 to move them because they can panic since this PR, so it's better to break compile compatibility (if any) than getting a panic inside a library.

tariq1890 · 2023-03-21T05:21:05Z

Hello :) how can we move this PR forward? It's been open for a while and I've been through multiple iterations already. Hoping to close this out

adrianchiris · 2023-03-21T07:26:34Z

/test-all

adrianchiris · 2023-03-21T07:27:29Z

thx for confirming @zeeke. ill merge this one once CI pass.

adrianchiris reviewed Feb 21, 2023

View reviewed changes

api/v1/helper.go Outdated Show resolved Hide resolved

tariq1890 force-pushed the pretty-cni-config branch from 995ce7b to 8e9acad Compare March 10, 2023 20:27

tariq1890 force-pushed the pretty-cni-config branch from 8e9acad to 311a3fc Compare March 10, 2023 20:29

tariq1890 requested a review from adrianchiris March 10, 2023 20:34

adrianchiris reviewed Mar 12, 2023

View reviewed changes

controllers/sriovibnetwork_controller.go Outdated Show resolved Hide resolved

controllers/sriovnetwork_controller.go Outdated Show resolved Hide resolved

tariq1890 force-pushed the pretty-cni-config branch from 73d1ff0 to 787ddd1 Compare March 13, 2023 02:25

tariq1890 force-pushed the pretty-cni-config branch from 787ddd1 to 0feb7d3 Compare March 13, 2023 02:47

tariq1890 requested a review from adrianchiris March 13, 2023 03:07

adrianchiris approved these changes Mar 13, 2023

View reviewed changes

zeeke reviewed Mar 13, 2023

View reviewed changes

test/util/util.go Outdated Show resolved Hide resolved

tariq1890 force-pushed the pretty-cni-config branch from 0feb7d3 to d24cea3 Compare March 13, 2023 17:18

tariq1890 force-pushed the pretty-cni-config branch from d24cea3 to 5809116 Compare March 13, 2023 17:18

tariq1890 force-pushed the pretty-cni-config branch from 5809116 to f725bf3 Compare March 13, 2023 17:21

tariq1890 requested review from adrianchiris and removed request for adrianchiris March 13, 2023 17:29

tariq1890 requested review from adrianchiris and zeeke and removed request for adrianchiris March 13, 2023 17:29

zeeke approved these changes Mar 13, 2023

View reviewed changes

adrianchiris reviewed Mar 14, 2023

View reviewed changes

controllers/helper.go Outdated Show resolved Hide resolved

adrianchiris reviewed Mar 14, 2023

View reviewed changes

controllers/sriovibnetwork_controller_test.go Show resolved Hide resolved

adrianchiris reviewed Mar 14, 2023

View reviewed changes

controllers/sriovnetwork_controller_test.go Show resolved Hide resolved

tariq1890 force-pushed the pretty-cni-config branch from f725bf3 to 0dbcfe7 Compare March 14, 2023 15:24

tariq1890 force-pushed the pretty-cni-config branch from 0dbcfe7 to 391e69a Compare March 16, 2023 05:26

tariq1890 added 2 commits March 15, 2023 22:30

pretty print CNI config JSON in Sriov[IB]Network CRs

eb0335b

make sriovnetwork CR test code package private

4c2698c

tariq1890 force-pushed the pretty-cni-config branch from 391e69a to 4c2698c Compare March 16, 2023 05:32

tariq1890 requested review from adrianchiris and zeeke and removed request for adrianchiris and zeeke March 16, 2023 05:33

adrianchiris merged commit 1e0d8ab into k8snetworkplumbingwg:master Mar 23, 2023

tariq1890 deleted the pretty-cni-config branch March 23, 2023 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pretty print CNI config when rendering NetAttachDefs #406

Pretty print CNI config when rendering NetAttachDefs #406

tariq1890 commented Feb 8, 2023

github-actions bot commented Feb 8, 2023

coveralls commented Feb 8, 2023 •

edited

Loading

tariq1890 commented Feb 9, 2023

tariq1890 commented Mar 1, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Mar 11, 2023

tariq1890 commented Mar 11, 2023

adrianchiris commented Mar 12, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

tariq1890 commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

zeeke left a comment

github-actions bot commented Mar 14, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

tariq1890 commented Mar 16, 2023

adrianchiris commented Mar 16, 2023 •

edited

Loading

zeeke commented Mar 16, 2023

tariq1890 commented Mar 21, 2023

adrianchiris commented Mar 21, 2023

adrianchiris commented Mar 21, 2023

Pretty print CNI config when rendering NetAttachDefs #406

Pretty print CNI config when rendering NetAttachDefs #406

Conversation

tariq1890 commented Feb 8, 2023

github-actions bot commented Feb 8, 2023

coveralls commented Feb 8, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4433914725

💛 - Coveralls

tariq1890 commented Feb 9, 2023

tariq1890 commented Mar 1, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Mar 10, 2023

github-actions bot commented Mar 11, 2023

tariq1890 commented Mar 11, 2023

adrianchiris commented Mar 12, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

tariq1890 commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

github-actions bot commented Mar 13, 2023

zeeke left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2023

github-actions bot commented Mar 16, 2023

github-actions bot commented Mar 16, 2023

tariq1890 commented Mar 16, 2023

adrianchiris commented Mar 16, 2023 • edited Loading

zeeke commented Mar 16, 2023

tariq1890 commented Mar 21, 2023

adrianchiris commented Mar 21, 2023

adrianchiris commented Mar 21, 2023

coveralls commented Feb 8, 2023 •

edited

Loading

adrianchiris commented Mar 16, 2023 •

edited

Loading