-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the Redhat virtual nic from udev rule #405
Skip the Redhat virtual nic from udev rule #405
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
7928eb6
to
ad8b361
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
we need to remove the Red Hat Virtio network device from the udev rule configuration if we don't remove it when running the config-daemon on a virtual node it will disconnect the node after a reboot even that the operator should not be installed on virtual environments that are not openstack we should not destroy the cluster if the operator is installed there Signed-off-by: Sebastian Sch <[email protected]>
ad8b361
to
308c15a
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 4133693093
💛 - Coveralls |
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
/test-all |
1 similar comment
/test-all |
we need to remove the Red Hat Virtio network device from the udev rule configuration if we don't remove it when running the config-daemon on a virtual node it will disconnect the node after a reboot even that the operator should not be installed on virtual environments that are not openstack we should not destroy the cluster if the operator is installed there
Signed-off-by: Sebastian Sch [email protected]