Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the Redhat virtual nic from udev rule #405

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Feb 8, 2023

we need to remove the Red Hat Virtio network device from the udev rule configuration if we don't remove it when running the config-daemon on a virtual node it will disconnect the node after a reboot even that the operator should not be installed on virtual environments that are not openstack we should not destroy the cluster if the operator is installed there

Signed-off-by: Sebastian Sch [email protected]

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba SchSeba force-pushed the skip_virtual_nic_udev branch from 7928eb6 to ad8b361 Compare February 9, 2023 11:15
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

we need to remove the Red Hat Virtio network device from the udev rule configuration
if we don't remove it when running the config-daemon on a virtual node it will disconnect the node after a reboot
even that the operator should not be installed on virtual environments that are not openstack
we should not destroy the cluster if the operator is installed there

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the skip_virtual_nic_udev branch from ad8b361 to 308c15a Compare February 9, 2023 11:16
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4133693093

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 25.299%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
api/v1/helper.go 3 40.6%
controllers/sriovibnetwork_controller.go 6 65.35%
Totals Coverage Status
Change from base Build 4126507459: 0.04%
Covered Lines: 1902
Relevant Lines: 7518

💛 - Coveralls

@adrianchiris
Copy link
Collaborator

/test-all

Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@SchSeba
Copy link
Collaborator Author

SchSeba commented Mar 12, 2023

/test-all

1 similar comment
@adrianchiris
Copy link
Collaborator

/test-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants