Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add printercolumn for syncStatus in SriovNetworkNodeState #404

Merged
merged 2 commits into from
Feb 21, 2023
Merged

add printercolumn for syncStatus in SriovNetworkNodeState #404

merged 2 commits into from
Feb 21, 2023

Conversation

tariq1890
Copy link
Contributor

It would be useful to see the status of all nodes when querying through SriovNetworkNodeStates

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Feb 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4131604285

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 25.276%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 67.33%
api/v1/helper.go 3 40.6%
Totals Coverage Status
Change from base Build 4126507459: 0.01%
Covered Lines: 1898
Relevant Lines: 7509
💛 - Coveralls

SchSeba
SchSeba approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea :)

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@tariq1890
Copy link
Contributor Author

@e0ne Added the printercolumn for Age. Please review

@tariq1890 tariq1890 requested a review from e0ne February 9, 2023 06:40
@tariq1890 tariq1890 requested a review from e0ne February 9, 2023 12:22
@tariq1890
Copy link
Contributor Author

@e0ne Would you be able to review ?

@adrianchiris
Copy link
Collaborator

@e0ne can we merge this one ?

e0ne
e0ne approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing my comments

@adrianchiris adrianchiris merged commit b4c00ca into k8snetworkplumbingwg:master Feb 21, 2023
@tariq1890 tariq1890 deleted the print-sync-status branch February 21, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tariq1890 @coveralls @adrianchiris @e0ne @SchSeba