Sort out binary installation in Makefile #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/cc @bn222 |
Pull Request Test Coverage Report for Build 4097427392
💛 - Coveralls |
zeeke
reviewed
Jan 18, 2023
| @@ -53,7 +54,7 @@ else | |||
| GOBIN=$(shell go env GOBIN) | |||
| endif | |||
|
|
|||
| GOLANGCI_LINT = $(GOBIN)/golangci-lint | |||
| GOLANGCI_LINT = $(BIN_DIR)/golangci-lint | |||
There was a problem hiding this comment.
We can also get rid of L51. Right?
# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
GOBIN=$(shell go env GOPATH)/bin
else
GOBIN=$(shell go env GOBIN)
endif
There was a problem hiding this comment.
yes this logic is no longer needed in Makefile. will remove
- Align all binaries to use a predefined bin dir in project - Add cleanup for bin dir - modify/rename go-get-tool to go-install-tool and clean up its logic - cleanup lint target - remove logic to determine GOBIN from go env cmd Signed-off-by: adrianc <[email protected]>
|
/lgtm thanks! |
adrianchiris
force-pushed
the
fix-makefile
branch
from
0b8e716 to
ebf853a
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
SchSeba
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: adrianc [email protected]