Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ginkgo/v2 CLI --junit-report flag #395

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Use ginkgo/v2 CLI --junit-report flag #395

merged 1 commit into from
Jan 18, 2023

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented Jan 15, 2023

This PR puts the ginkgo/v2 --junit-report CLI flag to use, which is recommended by the official docs.

Also, fix the ginkgo version on the run-e2e-conformance.sh script.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jan 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3924301767

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 25.29%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 65.35%
controllers/sriovnetworkpoolconfig_controller.go 4 54.89%
Totals Coverage Status
Change from base Build 3922356625: 0.01%
Covered Lines: 1899
Relevant Lines: 7509
💛 - Coveralls

@liornoy
Use ginkgo/v2 CLI --junit-report flag
ae949cc 
Update ginkgo version to v2.5.0 on the run-e2e-conformance.sh script.
Also use the --junit-report flag and remove the junit reporter code
from the test suites, making them thinner and cleaner.

Signed-off-by: liornoy <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

SchSeba
SchSeba approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SchSeba SchSeba merged commit bf4e122 into k8snetworkplumbingwg:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liornoy @coveralls @SchSeba @adrianchiris