Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sh-specific redirections. #389

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Remove sh-specific redirections. #389

merged 1 commit into from
Jan 1, 2023

Conversation

iancoolidge
Copy link

The "<<<" are not available in dash, used by deb-based OSes. Replaced it with "echo" and "|" which achieves same effect.

Reviewed-by: Chun-Feng (David) Liu [email protected]

@mskrocki @iancoolidge
Remove sh-specific redirections.
71155ee 
The "<<<" are not available in dash, used by deb-based OSes.
Replaced it with "echo" and "|" which achieves same effect.

Reviewed-by: Chun-Feng (David) Liu <[email protected]>
Change-Id: I8c8912debbc572fa7e37d3eb84d5d9236b8e0041
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@iancoolidge
Copy link
Author

/test-all

@iancoolidge iancoolidge marked this pull request as ready for review December 12, 2022 15:30
adrianchiris
adrianchiris approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward change. LGTM.

lets wait for CI to pass

@adrianchiris
Copy link
Collaborator

/test-all

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3677226919

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 25.33%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetwork_controller.go 2 67.0%
Totals Coverage Status
Change from base Build 3631034070: 0.05%
Covered Lines: 1902
Relevant Lines: 7509
💛 - Coveralls

@iancoolidge
Copy link
Author

I don't seem to have merge power. It looks like all tests passed

@SchSeba
Copy link
Collaborator

SchSeba commented Dec 18, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Dec 18, 2022
@adrianchiris adrianchiris merged commit 36d4923 into k8snetworkplumbingwg:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iancoolidge @adrianchiris @coveralls @SchSeba @mskrocki