Update Ginkgo to v2 #386
Merged
Update Ginkgo to v2 #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
Hi @liornoy , is it possible to split the commit in 2:
It would make the review much easier |
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Sure! np, done. |
|
Approved workflow run. @liornoy can you please have a look at the errors? Let me know if you think they are not related to the PR, maybe there are some build flakes. |
This commit bumps ginkgo to v2 and updates go.mod, go.sum and the vendor dir. Note: ginkgov2 requires go1.18, so go version is updated as well. Signed-off-by: liornoy <[email protected]>
Update source files to import ginkgo v2 and since the custom reporters feature is deprecated in ginkgo v2, modified the k8sreporter/reporter.go. Please note that ginkgo v2 has default configurations that lead to some code deletion in this commit: Ginkgo v2 default reporter prints with a new line. Ginkgo v2 by default configures ParallelTotal to 1. Ginkgo v2 by default configures TimeOut to 60 min. Signed-off-by: liornoy <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
@zeeke I updated .golangci.yml to solve the lint issues. (adding ginkgo/v2 to the whitelist) |
Pull Request Test Coverage Report for Build 3685350391
💛 - Coveralls |
adrianchiris
approved these changes
Dec 13, 2022
SchSeba
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ginkgo to v2.
Signed-off-by: liornoy [email protected]