Vdpa introduction #377

lmilleri · 2022-11-22T09:52:31Z

This PR is the first step on integrating vDPA in kubernetes containers.

API changes: a new attribute has been added to the policy.
The vdpaType can assume two values: virtio or vhost.
This PR implements the virtio mode only, vhost mode will be implemented in the future.

Supported card: NVIDIA Connect6-DX in switchdev mode (OVS HW offloading enabled)

The NIC is configured via the existing systemd services: switchdev-configuration-before-nm.service and switchdev-configuration-after-nm.service.

Webhook validation has been extended to check vDPA specific static configuration.

Note: this PR is depending on k8snetworkplumbingwg/sriov-network-device-plugin#450, so the go.mod needs to be amended after this PR is merged to master.
Please also consider that this vDPA solution depends on PR ovn-kubernetes/ovn-kubernetes#2664.

github-actions · 2022-11-22T09:52:43Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2022-11-22T10:00:07Z

Pull Request Test Coverage Report for Build 4253702965

24 of 36 (66.67%) changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.7%) to 25.767%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/v1/helper.go	0	1	0.0%
pkg/utils/switchdev.go	0	1	0.0%
pkg/plugins/generic/generic_plugin.go	13	23	56.52%

Files with Coverage Reduction	New Missed Lines	%
api/v1/helper.go	1	42.51%

Totals
Change from base Build 4241950765:	0.7%
Covered Lines:	1949
Relevant Lines:	7564

💛 - Coveralls

lmilleri · 2022-11-22T10:00:14Z

/cc @adrianchiris @SchSeba

github-actions · 2022-11-28T10:00:21Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

wizhaoredhat · 2022-11-28T20:34:27Z

Changes to the machine config, needs my changes here:
#381
Otherwise your changes won't apply to the node upon upgrade.

bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml

wizhaoredhat · 2022-12-02T16:14:38Z

/cc @zshi-redhat (for visibility)

SchSeba · 2022-12-05T15:37:56Z

/cc @bn222 @adrianchiris

github-actions · 2023-01-09T12:22:26Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml

github-actions · 2023-01-24T17:18:45Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

wizhaoredhat · 2023-02-07T17:18:05Z

/lgtm

SchSeba

overall looks great!

I just add some small comments related to the webhook validation we do

api/v1/helper_test.go

pkg/webhook/validate.go

github-actions · 2023-02-20T15:36:08Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-02-21T14:14:34Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2023-02-21T16:07:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

pkg/webhook/validate.go

The attribute vdpaType has been added to the policy It can assume the following values: - virtio - vhost (not implemented) Signed-off-by: Leonardo Milleri <[email protected]>

Signed-off-by: Leonardo Milleri <[email protected]>

bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml

adrianchiris · 2023-02-21T16:53:26Z

@lmilleri would you like adding a vdpa.md under doc ? :)
just to provide some general overview, requirements (kernel, hardware) plus example configuration of SNO

Signed-off-by: Leonardo Milleri <[email protected]>

lmilleri · 2023-02-22T09:22:58Z

@lmilleri would you like adding a vdpa.md under doc ? :) just to provide some general overview, requirements (kernel, hardware) plus example configuration of SNO

Good idea, will do

github-actions · 2023-02-22T09:24:51Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

lmilleri · 2023-02-22T10:37:14Z

@SchSeba @adrianchiris I have just pushed all the requested changes. Please have a look to it again

adrianchiris · 2023-02-22T12:16:47Z

/test-all

adrianchiris

Thx for addressing my comments @lmilleri LGTM!

lets wait for CI to pass

lmilleri · 2023-02-22T13:37:33Z

/test-all

lmilleri · 2023-02-22T13:42:22Z

@adrianchiris Nvidia e2e test CI is failing. I can't check for details, apparently 13.74.249.42 is not reachable

adrianchiris · 2023-02-22T14:21:21Z

/test-all

there is some issue with CI log server (should be solved during next week only).
also the CI machine had outdated go version, this was fixed. retriggering.

SchSeba

only one small comment

pkg/webhook/validate.go

Signed-off-by: Leonardo Milleri <[email protected]>

github-actions · 2023-02-23T14:38:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

bn222 · 2023-03-01T08:12:58Z

/lgtm

github-actions bot requested review from adrianchiris and SchSeba November 22, 2022 10:00

lmilleri force-pushed the vdpa branch from 5acb856 to 2f260a7 Compare November 28, 2022 10:00

wizhaoredhat reviewed Dec 2, 2022

View reviewed changes

bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml Outdated Show resolved Hide resolved

github-actions bot requested a review from zshi-redhat December 2, 2022 16:14

github-actions bot requested a review from bn222 December 5, 2022 15:38

lmilleri force-pushed the vdpa branch from 2f260a7 to 1324ffe Compare January 9, 2023 12:22

wizhaoredhat reviewed Jan 24, 2023

View reviewed changes

bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml Outdated Show resolved Hide resolved

lmilleri force-pushed the vdpa branch from 1324ffe to a241e65 Compare January 24, 2023 17:18

SchSeba reviewed Feb 19, 2023

View reviewed changes

api/v1/helper_test.go Show resolved Hide resolved

pkg/webhook/validate.go Outdated Show resolved Hide resolved

pkg/webhook/validate.go Outdated Show resolved Hide resolved

lmilleri force-pushed the vdpa branch from a241e65 to d65242b Compare February 20, 2023 15:35

lmilleri force-pushed the vdpa branch from d65242b to a151fc0 Compare February 21, 2023 14:14

lmilleri force-pushed the vdpa branch from a151fc0 to ddc9e14 Compare February 21, 2023 16:07

adrianchiris reviewed Feb 21, 2023

View reviewed changes

pkg/webhook/validate.go Outdated Show resolved Hide resolved

lmilleri added 2 commits February 21, 2023 16:45

vDPA API change

40eedf8

The attribute vdpaType has been added to the policy It can assume the following values: - virtio - vhost (not implemented) Signed-off-by: Leonardo Milleri <[email protected]>

Load vDPA virtio kernel driver

945f8d9

Signed-off-by: Leonardo Milleri <[email protected]>

adrianchiris reviewed Feb 21, 2023

View reviewed changes

bindata/manifests/switchdev-config/files/switchdev-configuration-after-nm.sh.yaml Show resolved Hide resolved

vDPA NIC configuration

72ebe9d

Signed-off-by: Leonardo Milleri <[email protected]>

lmilleri force-pushed the vdpa branch from ddc9e14 to 75772cd Compare February 22, 2023 09:24

adrianchiris approved these changes Feb 22, 2023

View reviewed changes

SchSeba reviewed Feb 23, 2023

View reviewed changes

pkg/webhook/validate.go Outdated Show resolved Hide resolved

lmilleri added 3 commits February 23, 2023 14:37

vDPA webhook validation

fb59886

Signed-off-by: Leonardo Milleri <[email protected]>

Dependency on govdpa v0.1.4

7eb4687

Signed-off-by: Leonardo Milleri <[email protected]>

Added vDPA document

f01bcd9

Signed-off-by: Leonardo Milleri <[email protected]>

lmilleri force-pushed the vdpa branch from 75772cd to f01bcd9 Compare February 23, 2023 14:38

github-actions bot added the lgtm label Mar 1, 2023

bn222 merged commit 13405c5 into k8snetworkplumbingwg:master Mar 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vdpa introduction #377

Vdpa introduction #377

lmilleri commented Nov 22, 2022

github-actions bot commented Nov 22, 2022

coveralls commented Nov 22, 2022 •

edited

Loading

lmilleri commented Nov 22, 2022

github-actions bot commented Nov 28, 2022

wizhaoredhat commented Nov 28, 2022

wizhaoredhat commented Dec 2, 2022

SchSeba commented Dec 5, 2022

github-actions bot commented Jan 9, 2023

github-actions bot commented Jan 24, 2023

wizhaoredhat commented Feb 7, 2023

SchSeba left a comment

github-actions bot commented Feb 20, 2023

github-actions bot commented Feb 21, 2023

github-actions bot commented Feb 21, 2023

adrianchiris commented Feb 21, 2023

lmilleri commented Feb 22, 2023

github-actions bot commented Feb 22, 2023

lmilleri commented Feb 22, 2023

adrianchiris commented Feb 22, 2023

adrianchiris left a comment

lmilleri commented Feb 22, 2023

lmilleri commented Feb 22, 2023

adrianchiris commented Feb 22, 2023

SchSeba left a comment

github-actions bot commented Feb 23, 2023

bn222 commented Mar 1, 2023

Vdpa introduction #377

Vdpa introduction #377

Conversation

lmilleri commented Nov 22, 2022

github-actions bot commented Nov 22, 2022

coveralls commented Nov 22, 2022 • edited Loading

Pull Request Test Coverage Report for Build 4253702965

💛 - Coveralls

lmilleri commented Nov 22, 2022

github-actions bot commented Nov 28, 2022

wizhaoredhat commented Nov 28, 2022

wizhaoredhat commented Dec 2, 2022

SchSeba commented Dec 5, 2022

github-actions bot commented Jan 9, 2023

github-actions bot commented Jan 24, 2023

wizhaoredhat commented Feb 7, 2023

SchSeba left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 20, 2023

github-actions bot commented Feb 21, 2023

github-actions bot commented Feb 21, 2023

adrianchiris commented Feb 21, 2023

lmilleri commented Feb 22, 2023

github-actions bot commented Feb 22, 2023

lmilleri commented Feb 22, 2023

adrianchiris commented Feb 22, 2023

adrianchiris left a comment

Choose a reason for hiding this comment

lmilleri commented Feb 22, 2023

lmilleri commented Feb 22, 2023

adrianchiris commented Feb 22, 2023

SchSeba left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2023

bn222 commented Mar 1, 2023

coveralls commented Nov 22, 2022 •

edited

Loading