New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imagePullSecrets rendering #364

Merged

SchSeba merged 1 commit into k8snetworkplumbingwg:master from e0ne:pull-secrets-fix

Dec 20, 2022

Collaborator

e0ne commented Sep 22, 2022

No description provided.


          Fix imagePullSecrets rendering

7e263d1

github-actions bot commented Sep 22, 2022

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls commented Sep 22, 2022

Pull Request Test Coverage Report for Build 3105000053

0 of 0 changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 25.037%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovibnetwork_controller.go	2	67.33%
controllers/sriovnetwork_controller.go	5	67.0%

Totals
Change from base Build 3097501597:	0.0%
Covered Lines:	1855
Relevant Lines:	7409

💛 - Coveralls

Eoghan1232 approved these changes

View reviewed changes

Member

zeeke commented Oct 11, 2022

LGTM

Contributor

jjuele commented Oct 28, 2022

Can one of the admins verify this patch?

Collaborator Author

e0ne commented Dec 19, 2022

@SchSeba @adrianchiris could you please take a look on this PR once you have a time?

adrianchiris approved these changes

View reviewed changes

Collaborator

SchSeba commented Dec 20, 2022

/lgtm

SchSeba merged commit 788d76f into k8snetworkplumbingwg:master

github-actions bot added the lgtm label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm