load vhost-net kernel module #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 2739070269
💛 - Coveralls |
zeeke
reviewed
Jul 25, 2022
pkg/daemon/daemon.go
Outdated
| @@ -905,6 +906,12 @@ func tryEnableTun() { | |||
| } | |||
| } | |||
|
|
|||
| func tryEnableVhostNet() { | |||
| if err := utils.LoadKernelModule("vhost-net"); err != nil { | |||
| glog.Errorf("tryEnableTun(): VHOST-NET kernel module not loaded: %v", err) | |||
There was a problem hiding this comment.
typo: please change to tryEnableVhostNet()
zeeke
reviewed
Jul 25, 2022
pkg/daemon/daemon.go
Outdated
| @@ -905,6 +906,12 @@ func tryEnableTun() { | |||
| } | |||
| } | |||
|
|
|||
| func tryEnableVhostNet() { | |||
| if err := utils.LoadKernelModule("vhost-net"); err != nil { | |||
There was a problem hiding this comment.
Maybe better to change to vhost_net, as lsmod print modules with underscore and we would not grep it in load-kmod.sh
lsmod | grep "vhost_net"
vhost_net 28672 0
vhost 49152 1 vhost_net
tap 28672 1 vhost_net
tun 49152 4 vhost_net
Suggested change
| if err := utils.LoadKernelModule("vhost-net"); err != nil { | |
| if err := utils.LoadKernelModule("vhost_net"); err != nil { |
There was a problem hiding this comment.
both of them work I am fine chaining :)
This commit is needed when using DPDK with vhost-net in virtio mode. We must load the vhost-net kernel module if we don't want the dpdk application to run with privilege Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
load_vhost_kernel_module
branch
from
848923c to
3e8d487
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
LGTM |
adrianchiris
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is needed when using DPDK with vhost-net in virtio mode.
We must load the vhost-net kernel module if we don't want the dpdk
application to run with privilege
Signed-off-by: Sebastian Sch [email protected]