Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Generate random mac address when virtual mac address is zero." #327

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

adrianchiris
Copy link
Collaborator

Reverts #325

  • There should be acceptance from more than one company according to organization policy
  • There are still concerns for this PR which i have.
    • pensando is not officially supported so why are we adding WA for this ?
    • why isnt mac addresss set in driver ?
    • if it is deemed un-nessecary for pensando kenrel folks then this perhaps should be handled in a vendor plugin and not in main code. this requires further discussion

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@bn222
Copy link
Collaborator

bn222 commented Jun 23, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Jun 23, 2022
bn222 referenced this pull request Jun 23, 2022
Generate random mac address when virtual mac address is zero.
@adrianchiris
Copy link
Collaborator Author

@vrindle please re-propose the original PR and lets have further discussion on it

  1. follow this doc to add support for pensando to begin with : https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md
  2. re propose PR for the WA with pensando driver

@adrianchiris adrianchiris merged commit 96e4dfe into master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants