Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intel E810 PF 1591 Network Adapter #326

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Add Intel E810 PF 1591 Network Adapter #326

merged 1 commit into from
Jun 27, 2022

Conversation

novacain1
Copy link
Contributor

@novacain1 novacain1 commented Jun 22, 2022

The Intel series of E810 cards with a 1591 PF ID need to be added to the supported card listing in OpenShift. This PCI ID belongs to Intel.

Cards have Vendor ID 8086, PF 1591, and VF of 1889.

Note: Silicom TimeSync cards (STS2, STS4, etc) contain this embedded E810 in those particular network adapters.

Cards were tested internally in Red Hat and found to be passing. Request of this PR is to get them to the supported list of devices.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@novacain1 thanks for your contributions. Please follow this https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md guideline to add new supported hardware. Alse, please rebase your PR to not include merge commit

@SchSeba
Copy link
Collaborator

SchSeba commented Jun 23, 2022

/cc @Eoghan1232

@github-actions github-actions bot requested a review from Eoghan1232 June 23, 2022 09:00
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

deploy/configmap.yaml Outdated Show resolved Hide resolved
@Eoghan1232
Copy link
Collaborator

just added a comment, name change.
Otherwise LGTM.

Please also update the supported-hardware ReadMe.
https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@novacain1 novacain1 requested a review from e0ne June 27, 2022 00:52
@SchSeba
Copy link
Collaborator

SchSeba commented Jun 27, 2022

/lgtm

@github-actions github-actions bot added the lgtm label Jun 27, 2022
@e0ne
Copy link
Collaborator

e0ne commented Jun 27, 2022

I'm OK with a patch itself, just a few nits on it: could you please squash commits in to one and remove bugzilla link from the upstream PR?

@adrianchiris
Copy link
Collaborator

lets squash to single commit and update commit message like @e0ne suggested. then i think we are good 2 go

update naming and feedback
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris merged commit 37b62c5 into k8snetworkplumbingwg:master Jun 27, 2022
SchSeba pushed a commit to SchSeba/sriov-network-operator-1 that referenced this pull request Jul 28, 2022
The Intel series of E810 cards with a 1591 PF ID is added to the supported card listing

- Update docs with newly supported hardware
- Update supported device ids in config map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants