-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intel E810 PF 1591 Network Adapter #326
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@novacain1 thanks for your contributions. Please follow this https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/doc/supported-hardware.md guideline to add new supported hardware. Alse, please rebase your PR to not include merge commit
/cc @Eoghan1232 |
Thanks for your PR,
To skip the vendors CIs use one of:
|
just added a comment, name change. Please also update the supported-hardware ReadMe. |
Thanks for your PR,
To skip the vendors CIs use one of:
|
/lgtm |
I'm OK with a patch itself, just a few nits on it: could you please squash commits in to one and remove bugzilla link from the upstream PR? |
lets squash to single commit and update commit message like @e0ne suggested. then i think we are good 2 go |
update naming and feedback
Thanks for your PR,
To skip the vendors CIs use one of:
|
The Intel series of E810 cards with a 1591 PF ID is added to the supported card listing - Update docs with newly supported hardware - Update supported device ids in config map
The Intel series of E810 cards with a 1591 PF ID need to be added to the supported card listing in OpenShift. This PCI ID belongs to Intel.
Cards have Vendor ID 8086, PF 1591, and VF of 1889.
Note: Silicom TimeSync cards (STS2, STS4, etc) contain this embedded E810 in those particular network adapters.
Cards were tested internally in Red Hat and found to be passing. Request of this PR is to get them to the supported list of devices.