Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YAMLs to support k8s (kubeadm) v1.24 #308

Conversation

adrianchiris
Copy link
Collaborator

With Kubernetes 1.24, master nodes are now
labeld and tainted as node-role.kubernetes.io/control-plane

Support this in sriov network operator by:

  • extending tolerations in relevant yaml files
  • adjusting node affinity in relevant yaml files
  • modify helm chart to deploy operator based on node affinity
    and not node selector

Signed-off-by: Adrian Chiris [email protected]

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris adrianchiris changed the title Update YAMLs to support k8s (kubeadm) v1.24 [DoNotMerge] Update YAMLs to support k8s (kubeadm) v1.24 May 22, 2022
@adrianchiris
Copy link
Collaborator Author

/test-all

With Kubernetes 1.24, master nodes are now
labeld and tainted as `node-role.kubernetes.io/control-plane`

Support this in sriov network operator by:

- extending tolerations in relevant yaml files
- adjusting node affinity in relevant yaml files
- modify helm chart to deploy operator based on node affinity
  and not node selector

Signed-off-by: Adrian Chiris <[email protected]>
@adrianchiris adrianchiris force-pushed the support-k8s-1.24-kubeadm-taints branch from b420485 to f42c350 Compare May 22, 2022 09:08
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@adrianchiris
Copy link
Collaborator Author

/test-all

@adrianchiris adrianchiris changed the title [DoNotMerge] Update YAMLs to support k8s (kubeadm) v1.24 Update YAMLs to support k8s (kubeadm) v1.24 May 22, 2022
@abdallahyas
Copy link
Contributor

@adrianchiris can you push to merge this?

@adrianchiris
Copy link
Collaborator Author

@bn222 @SchSeba can you take a quick look :)

@SchSeba
Copy link
Collaborator

SchSeba commented Jun 1, 2022

@adrianchiris please wait I am validating this on OCP running with k8s 1.24

Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adrianchiris adrianchiris merged commit 23d3a97 into k8snetworkplumbingwg:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants