Generic Plugin Reset interface on error #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Chiris <[email protected]>
If error occures during sriov configuration in generic plugin, config daemon will log the error and requeue the request to reconcile the node. On the next run, when generic plugin Apply() method is called, interface configuration may be skipped, leaving the interface partially configured. To ensure generic plugin re-configures the interface on the next iteration, we reset the interface before returning an error. This will also ensure that a drain will be requested as well. Signed-off-by: Adrian Chiris <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/test-all |
|
@SchSeba PTAL |
Eoghan1232
approved these changes
May 5, 2022
|
/test-e2e-nvidia-all |
|
LGTM |
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If error occures during sriov configuration in
generic plugin, config daemon will log the error
and requeue the request to reconcile the node.
On the next run, when generic plugin Apply() method
is called, interface configuration may be skipped,
leaving the interface partially configured.
To ensure generic plugin re-configures the interface
on the next iteration, we reset the interface
before returning an error.