Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #289

Merged
merged 1 commit into from
May 8, 2022
Merged

Conversation

rollandf
Copy link
Contributor

This PR fix issues found with:
golangci-lint run --disable-all -E unused

$ golangci-lint run --disable-all -E unused
test/util/k8sreporter/reporter.go:152:30: func `(*KubernetesReporter).logNetworks` is unused (unused)
controllers/suite_test.go:51:5: var `cfg` is unused (unused)
cmd/webhook/start.go:33:2: var `startOpts` is unused (unused)
controllers/sriovoperatorconfig_controller.go:51:5: var `injectorServiceCaCmVersion` is unused (unused)
controllers/sriovoperatorconfig_controller.go:52:5: var `webhookServiceCaCmVersion` is unused (unused)
pkg/plugins/virtual/virtual_plugin.go:136:6: func `isCommandNotFound` is unused (unused)
test/conformance/tests/sriov_operator.go:2002:6: func `isPodConditionUnschedulable` is unused (unused)
test/conformance/tests/sriov_operator.go:1981:6: func `createUnschedulableTestPod` is unused (unused)
pkg/daemon/daemon.go:91:2: field `dpReboot` is unused (unused)
pkg/daemon/daemon.go:110:6: type `workItem` is unused (unused)
pkg/daemon/daemon.go:182:19: func `(*Daemon).annotateUnsupportedNicIdConfigMap` is unused (unused)
pkg/daemon/daemon.go:67:2: field `namespace` is unused (unused)
test/e2e/e2e_tests_suite_test.go:59:5: var `sriovInfos` is unused (unused)
pkg/webhook/validate.go:260:6: func `keys` is unused (unused)
test/util/discovery/discovery.go:74:6: func `containsNode` is unused (unused)
test/validation/tests/validation.go:23:2: var `machineConfigPoolNodeSelector` is unused (unused)

Signed-off-by: Fred Rolland [email protected]

This PR fix issues found with:
golangci-lint run --disable-all -E unused

Signed-off-by: Fred Rolland <[email protected]>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf
Copy link
Contributor Author

Related to issue #288

@adrianchiris
Copy link
Collaborator

/test-all

Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good clean up, @rollandf! It would be great to add this check to the CI

@zeeke
Copy link
Member

zeeke commented Apr 27, 2022

Great clean-up! LGTM

@rollandf
Copy link
Contributor Author

It's a good clean up, @rollandf! It would be great to add this check to the CI

@e0ne , absolutely. I opened an issue for it: #288

@adrianchiris adrianchiris merged commit 26fb2b6 into k8snetworkplumbingwg:master May 8, 2022
@rollandf rollandf deleted the unused branch June 6, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants