Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to CreateSriovPolicy #285

Merged

Conversation

mmirecki
Copy link
Contributor

@mmirecki mmirecki commented Apr 26, 2022

This code is reused in other repos which rely on sriov. One of those repos is the CNF repo which provides a suite to check a cluster.

In this repo the CreateSriovPolicy function is used, but if a custom parameter (like NeedVhostNet) is needed, the function is just inlined: here

To avoid this, a tweaking function is added to parameters.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne
Copy link
Collaborator

e0ne commented Apr 26, 2022

hi @mmirecki. please, add a description why do we need this change

@mmirecki
Copy link
Contributor Author

hi @mmirecki. please, add a description why do we need this change

Hi @e0ne , description added.

@SchSeba
Copy link
Collaborator

SchSeba commented Apr 26, 2022

@mmirecki please run go fmt

@mmirecki mmirecki force-pushed the addoptions_createnetwork branch from 3574a22 to a66c153 Compare April 28, 2022 08:53
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@mmirecki
Copy link
Contributor Author

@mmirecki please run go fmt

done

@e0ne
Copy link
Collaborator

e0ne commented May 12, 2022

@mmirecki thanks for the update. I don't have any argues to block this PR

@zeeke
Copy link
Member

zeeke commented May 12, 2022

LGTM

@SchSeba SchSeba merged commit 388c623 into k8snetworkplumbingwg:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants