Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init NicIdMap on the config daemon startup #280

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Init NicIdMap on the config daemon startup #280

merged 1 commit into from
Apr 13, 2022

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Apr 7, 2022

After PR #252 is merged there is a race condition between NicIdMap
init and accec to it.
This patch moves InitNicIdMap function call before NicIdMap will be
used in node writer and config daemon run function.

Closes-Bug: #279

@e0ne
Init NicIdMap on the config daemon startup
bf19fc2 
After PR k8snetworkplumbingwg#252 is merged there is a race condition between NicIdMap
init and accec to it.
This patch moves InitNicIdMap function call before NicIdMap will be
used in node writer and config daemon run function.

Closes-Bug: k8snetworkplumbingwg#279
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf
Copy link
Contributor

rollandf commented Apr 7, 2022

/lgtm

@zeeke
Copy link
Member

zeeke commented Apr 12, 2022

lgtm

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 13, 2022

/retest-all

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 13, 2022

/retest

@e0ne e0ne closed this Apr 13, 2022
@e0ne e0ne reopened this Apr 13, 2022
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne
Copy link
Collaborator Author

e0ne commented Apr 13, 2022

/test-all

@SchSeba
Copy link
Collaborator

SchSeba commented Apr 13, 2022

/lgtm

@SchSeba SchSeba merged commit 84539c7 into k8snetworkplumbingwg:master Apr 13, 2022
@github-actions github-actions bot added the lgtm label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@e0ne @rollandf @zeeke @SchSeba @adrianchiris @ykulazhenkov