fix: attach scheme to client for oc infra call #237
Conversation
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
pkg/utils/cluster.go
Outdated
| @@ -42,6 +42,7 @@ func k8sSingleNodeClusterStatus(c client.Client) (bool, error) { | |||
|
|
|||
| func openshiftSingleNodeClusterStatus(c client.Client) (bool, error) { | |||
| infra := &configv1.Infrastructure{} | |||
| configv1.AddToScheme(c.Scheme()) | |||
There was a problem hiding this comment.
Wondering if this should be added here: https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/master/main.go#L57
There was a problem hiding this comment.
I wasn't sure either. I figured since this is a code path for Openshift clusters only it would be best to keep it close to the one spot it's being used. Would you rather I move it to main.go?
There was a problem hiding this comment.
Maybe we can keep it here and move it later if needed?
@SchSeba wdyt?
There was a problem hiding this comment.
I think is better to move this to the main.go file to have all the scheme changes/configuration in one please
There was a problem hiding this comment.
Sounds good, moved it to main.go
eggfoobar
force-pushed
the
fix_oc_scheme
branch
from
f5163fa to
0e34e53
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
updated to attach scheme to client for infra call updated error message output to bubble up error from single node call Signed-off-by: ehila <[email protected]>
eggfoobar
force-pushed
the
fix_oc_scheme
branch
from
0e34e53 to
6063069
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
|
/lgtm |
updated to attach scheme to client for infra call
updated error message output to bubble up error from single node call
Signed-off-by: ehila [email protected]