Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang to v1.17 #228

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update golang to v1.17 #228

merged 1 commit into from
Jan 25, 2022

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jan 17, 2022 •
edited
Loading

This patch introduces following changes:
* explicitly set go version to v1.17 in GitHub actions
* updates go.mod file and vendored packages
* updates go version in Dockerfiles
* uses 'go install' instead of 'go get' [1]

[1] https://go.dev/doc/go-get-install-deprecation

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba
Copy link
Collaborator

SchSeba commented Jan 18, 2022

Thanks for the contribution!

/lgtm

@github-actions github-actions bot added the lgtm label Jan 18, 2022
@adrianchiris
Copy link
Collaborator

adrianchiris commented Jan 19, 2022 •
edited
Loading

uses 'go install' instead of 'go get' [1]

@e0ne where are you using go install instead of go get ?

i see:

sriov-network-operator/Makefile

Line 156 in 4baf8e5

define go-get-tool

@e0ne
Copy link
Collaborator Author

e0ne commented Jan 19, 2022

@adrianchiris I updated PR description. It requires more investigation how to install controller-gen using 'go install'

@adrianchiris
Copy link
Collaborator

looking at Makefile it just replacing go get with go install in go-get-tool mind trying it out ? :)

@e0ne
Copy link
Collaborator Author

e0ne commented Jan 19, 2022

looking at Makefile it just replacing go get with go install in go-get-tool mind trying it out ? :)

Unfortunately, it's not so easy:

go: creating new go.mod: module tmp
Downloading sigs.k8s.io/controller-tools/cmd/[email protected]
go install: sigs.k8s.io/controller-tools/cmd/[email protected]: cannot query module due to -mod=vendor
make: *** [Makefile:149: controller-gen] Error 1

Simple version bump doesn't work for me. I didn't dig deep into this issue, so I left this change to another PR

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne
Copy link
Collaborator Author

e0ne commented Jan 19, 2022

@adrianchiris 'go install' is now used.

@e0ne e0ne marked this pull request as draft January 20, 2022 07:47
@adrianchiris
Copy link
Collaborator

@e0ne it seems to fail trying to install kustomize

i will open an issue on it, we will need to deal with before updating to go 1.18.

@adrianchiris adrianchiris mentioned this pull request Jan 20, 2022
Closed
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne e0ne marked this pull request as ready for review January 20, 2022 09:14
@adrianchiris
Copy link
Collaborator

@e0ne could you rebase and fix conflicts ?

@e0ne
Update golang to v1.17
0790bd4 
This patch introduces following changes:
* explicitly set go version to v1.17 in GitHub actions
* updates go.mod file and vendored packages
* updates go version in Dockerfiles

'go install' instead of 'go get' [1] will be used once k8snetworkplumbingwg#231
is fixed.

[1] https://go.dev/doc/go-get-install-deprecation
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne
Copy link
Collaborator Author

e0ne commented Jan 20, 2022

@adrianchiris done

@adrianchiris
Copy link
Collaborator

@SchSeba @zshi-redhat can we merge this ?

@SchSeba
Copy link
Collaborator

SchSeba commented Jan 25, 2022

/lgtm

@SchSeba SchSeba merged commit 586ccc9 into k8snetworkplumbingwg:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e0ne @SchSeba @adrianchiris