validate: allow netFilter to be set alone in NicSelector #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign zshi-redhat |
EmilienM
changed the title
EmilienM
changed the title
atyronesmith
reviewed
Dec 2, 2021
zshi-redhat
approved these changes
Dec 3, 2021
|
/cc @pliurh |
In `staticValidateSriovNetworkNodePolicy`, we now allow a NicSelector to only have NetFilter defined. This will be useful for the OpenStack platform, where we can request a Network Node Policy only by its Network ID.
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@zshi-redhat @pliurh @atyronesmith could I backport it to older releases, I would like to have it for 4.8 if possible. Thanks |
@EmilienM I think it could, I don't see any obvious risk backporting this fix. |
|
@zshi-redhat thanks. Done via #212 |
EmilienM
added a commit
to EmilienM/sriov-network-operator
that referenced
this pull request
Dec 7, 2021
…lector Backport of k8snetworkplumbingwg/sriov-network-operator#210. In `staticValidateSriovNetworkNodePolicy`, we now allow a NicSelector to only have NetFilter defined. This will be useful for the OpenStack platform, where we can request a Network Node Policy only by its Network ID.
EmilienM
added a commit
to EmilienM/sriov-network-operator
that referenced
this pull request
Dec 8, 2021
…lector Backport of k8snetworkplumbingwg/sriov-network-operator#210. In `staticValidateSriovNetworkNodePolicy`, we now allow a NicSelector to only have NetFilter defined. This will be useful for the OpenStack platform, where we can request a Network Node Policy only by its Network ID.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/sriov-network-operator
that referenced
this pull request
Feb 2, 2022
…lector Backport of k8snetworkplumbingwg/sriov-network-operator#210. In `staticValidateSriovNetworkNodePolicy`, we now allow a NicSelector to only have NetFilter defined. This will be useful for the OpenStack platform, where we can request a Network Node Policy only by its Network ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
staticValidateSriovNetworkNodePolicy, we now allow a NicSelector toonly have NetFilter defined.
This will be useful for the OpenStack platform, where we can request a
Network Node Policy only by its Network ID.