-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pr-ci-triggers workflow #209
Add pr-ci-triggers workflow #209
Conversation
There seem to be a limitation in github where forks are not allowed to read |
.github/workflows/pr-ci-triggers.yml
Outdated
pull_request: | ||
|
||
jobs: | ||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job name : vendor-ci
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched it to vendors-ci-triggers-list
, since i think this would be more descriptive, WDYT?
@@ -59,7 +59,7 @@ | |||
failure-status: "Build Failed, comment `/test-e2e-all`, /test-e2e-nvidia-all, or `/test-all` to retrigger" | |||
error-status: "Build Failed, comment `/test-e2e-all`, /test-e2e-nvidia-all, or `/test-all` to retrigger" | |||
status-context: '{project} CI' | |||
trigger-phrase: ".*/test-(all|e2e-all|e2e-nvidia-all(,| |$)).*" | |||
trigger-phrase: "^(?!Thanks for your PR).*/test-(all|e2e-all|e2e-nvidia-all(,| |$)).*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need this change ? the message does not contain the "full" trigger i.e /<trigger-name>
but rather just <trigger-name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should contain the full trigger, to make copy pasting it easier
49ccd76
to
eca8090
Compare
2b3f2e1
to
628c3c5
Compare
Added the pr-ci-triggers github workflow to print out available vendors CIs trigger phrases.
628c3c5
to
dabe961
Compare
Added the pr-ci-triggers github workflow to print out available
vendors CIs trigger phrases.