Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pr-ci-triggers workflow #209

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

abdallahyas
Copy link
Contributor

Added the pr-ci-triggers github workflow to print out available
vendors CIs trigger phrases.

@abdallahyas
Copy link
Contributor Author

There seem to be a limitation in github where forks are not allowed to read secrets and so it is not possible to comment on the PR.

pull_request:

jobs:
test:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job name : vendor-ci ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched it to vendors-ci-triggers-list, since i think this would be more descriptive, WDYT?

@@ -59,7 +59,7 @@
failure-status: "Build Failed, comment `/test-e2e-all`, /test-e2e-nvidia-all, or `/test-all` to retrigger"
error-status: "Build Failed, comment `/test-e2e-all`, /test-e2e-nvidia-all, or `/test-all` to retrigger"
status-context: '{project} CI'
trigger-phrase: ".*/test-(all|e2e-all|e2e-nvidia-all(,| |$)).*"
trigger-phrase: "^(?!Thanks for your PR).*/test-(all|e2e-all|e2e-nvidia-all(,| |$)).*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this change ? the message does not contain the "full" trigger i.e /<trigger-name> but rather just <trigger-name>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it should contain the full trigger, to make copy pasting it easier

@abdallahyas abdallahyas force-pushed the add-hello-work-flow branch 2 times, most recently from 49ccd76 to eca8090 Compare December 7, 2021 11:59
@abdallahyas abdallahyas marked this pull request as draft December 7, 2021 12:02
@abdallahyas abdallahyas force-pushed the add-hello-work-flow branch 17 times, most recently from 2b3f2e1 to 628c3c5 Compare December 7, 2021 13:40
@abdallahyas abdallahyas marked this pull request as ready for review December 7, 2021 13:47
Added the pr-ci-triggers github workflow to print out available
vendors CIs trigger phrases.
@pliurh pliurh merged commit 923cb4d into k8snetworkplumbingwg:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants