Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OVS HWOL: set flow steering mode for eswitch device #208

Conversation

zshi-redhat
Copy link
Collaborator

@zshi-redhat zshi-redhat commented Nov 29, 2021

Add a knob for steering mode configuration, defaults to dmfs

Signed-off-by: Zenghui Shi [email protected]

@pliurh
Copy link
Collaborator

pliurh commented Dec 6, 2021

Can you add a description to the commit? IIUC, the flow_steering_mode flag is only valid for Mellanox NICs, shall we render this conditionally?

@adrianchiris
Copy link
Collaborator

Can you add a description to the commit? IIUC, the flow_steering_mode flag is only valid for Mellanox NICs, shall we render this conditionally?

ATM also the code above it (unbind mlx5_core) is only valid for mlnx NIC so not sure if this bit is required to be rendered conditionally.

LGTM from my side, A bit more context in commit message is appreciated :)

@zshi-redhat
Copy link
Collaborator Author

Can you add a description to the commit? IIUC, the flow_steering_mode flag is only valid for Mellanox NICs, shall we render this conditionally?

Updated the commit message.

ATM also the code above it (unbind mlx5_core) is only valid for mlnx NIC so not sure if this bit is required to be rendered conditionally.

Yeah, that's what I'm going to say, I agree that we need to remove the hardcoded driver. I think this can be done in a separate PR.

LGTM from my side, A bit more context in commit message is appreciated :)

@pliurh
Copy link
Collaborator

pliurh commented Dec 13, 2021

Updated the commit message.

I cannot see the commit message.

Add a knob for steering mode configuration, defaults to dmfs

Signed-off-by: Zenghui Shi <[email protected]>
@zshi-redhat zshi-redhat force-pushed the ovs-hw-offload-software-steering branch from f8302f8 to 003ab9d Compare December 14, 2021 03:45
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zshi-redhat
Copy link
Collaborator Author

Updated the commit message.

I cannot see the commit message.

I updated in this PR which would appear in the merge log.
Also updated in the commit message this time.

@pliurh pliurh merged commit c822c05 into k8snetworkplumbingwg:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants