Reload VF driver only when rdma is enabled #207
Conversation
|
/cc @Mmduh-483 |
|
@pliurh Will this fix be backported to lower versions? If so, I'd prefer to not changing API. My understanding is we will eventually remove this once kernel fix is in place. |
If we want to fix that 4.6 bug, we need to backport it. Without modifying API, the config daemon cannot know if a VF will be used for ROCE. I don't know when it will be fixed in the kernel. |
pkg/utils/utils.go
Outdated
| func setVfsGuid(iface *sriovnetworkv1.Interface) error { | ||
| glog.Infof("setVfsGuid(): device %s", iface.PciAddress) | ||
| pfLink, err := netlink.LinkByName(iface.Name) | ||
| func setVfsGuid(vfAddr string, pfLink netlink.Link) error { |
There was a problem hiding this comment.
imo the name: setVfGUID or setVfGuid is more appropriate now.
pkg/utils/utils.go
Outdated
| func setVfsAdminMac(iface *sriovnetworkv1.InterfaceExt) error { | ||
| glog.Infof("setVfsAdminMac(): device %s", iface.PciAddress) | ||
| pfLink, err := netlink.LinkByName(iface.Name) | ||
| func setVfsAdminMac(vfAddr string, pfLink netlink.Link, isRdma bool) error { |
There was a problem hiding this comment.
imo the name: setVFAdminMac or setVFAdminMAC is more appropriate now.
pkg/utils/utils.go
Outdated
| return err | ||
| } | ||
| if isRdma { | ||
| glog.Infof("setVfsAdminMac(): unbind driver for %s", vfAddr) |
There was a problem hiding this comment.
should we add a method to handle the driver unbind and move the unbind logic out of SetVfAdminMac and SetVfGuid ?
so that these functions do exactly what their name say ?
e.g add a function : UnbindDriverIfNeeded() and call it from configureSriovDevice ?
To set the GUID to VF, we need to set the admin MAC and reload the VF driver. It will take a long time if users set big 'numVFs'. This PR changes the logic to only reload the VF driver when isRdma is set. So that, users not using ROCE will no longer need to wait for the VF driver reload.
SriovNetworkNodeState is outdated. IsRdma field was introduced in the PR k8snetworkplumbingwg#207. This patch syncs CRDs between config/crd/bases and helm chart.
SriovNetworkNodeState is outdated. IsRdma field was introduced in the PR k8snetworkplumbingwg#207. This patch syncs CRDs between config/crd/bases and helm chart.
To set the GUID to VF, we need to set the admin MAC and reload the VF driver. It will take a long time if users set big 'numVFs'. This PR changes the logic to only reload the VF driver when
isRdmais set. So that, users not using ROCE will no longer need to wait for the VF driver reload.