Remove the secure boot checker pod #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchSeba
force-pushed
the
fix_secureboot_validation
branch
from
7a4beea to
0a65935
Compare
|
/lgtm |
e0ne
approved these changes
Nov 25, 2021
test/util/cluster/cluster.go
Outdated
| @@ -308,5 +309,10 @@ func GetNodeSecureBootState(clients *testclient.ClientSet, nodeName, namespace s | |||
| return false, err | |||
| } | |||
|
|
|||
| err = clients.Pods(namespace).Delete(context.Background(), runningPod.Name, metav1.DeleteOptions{GracePeriodSeconds: pointer.Int64Ptr(0)}) | |||
There was a problem hiding this comment.
should we use defer to delete the pod in case of early return ?
There was a problem hiding this comment.
sorry for the late response :)
SchSeba
force-pushed
the
fix_secureboot_validation
branch
from
0a65935 to
e835e8f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
This commit removes the pod that is created to validate if the node has secure boot enable or not Before this PR after every test running there are test pods in the sriov operator namespace that does not get clean Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
fix_secureboot_validation
branch
from
e835e8f to
eb8654d
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the pod that is created to validate if the node has
secure boot enable or not
Before this PR after every test running there are test pods in the sriov
operator namespace that does not get clean