Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add a workaround for BZ 1875338" #204

Merged

Conversation

zshi-redhat
Copy link
Collaborator

This reverts commit fa7011a.

Reverts since the aforementioned bz is fixed

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2021

This pull request introduces 2 alerts when merging e1c0958 into f4cc0f3 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable

glog.Warningf("configSriovDevice(): W/A rebind for PCI %s", addr)

// keep VF MTU align with PF's
mtu := ifaceStatus.Mtu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined, but not used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

This reverts commit fa7011a.

Reverts since the aforementioned bz is fixed
@zshi-redhat zshi-redhat force-pushed the revert-bz1875338-workaround branch from e1c0958 to cd553ae Compare November 22, 2021 08:34
@pliurh
Copy link
Collaborator

pliurh commented Nov 22, 2021

/lgtm

@github-actions github-actions bot added the lgtm label Nov 22, 2021
@SchSeba
Copy link
Collaborator

SchSeba commented Nov 23, 2021

/lgtm

@SchSeba SchSeba merged commit 2870c32 into k8snetworkplumbingwg:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants